Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddFactor should not require the variables to exist #835

Open
GearsAD opened this issue Jan 9, 2022 · 2 comments
Open

AddFactor should not require the variables to exist #835

GearsAD opened this issue Jan 9, 2022 · 2 comments
Labels
Milestone

Comments

@GearsAD
Copy link
Collaborator

GearsAD commented Jan 9, 2022

As a user I would like to add factors before their variables exist. In CGDFG this can be done by adding phantom variables until the full variable exists.

TBD should this be added to all DFG or just CGDFG?

@dehann dehann added this to the v0.0.x milestone Jan 9, 2022
@dehann dehann added enhancement New feature or request needs testing testing and removed testing labels Jan 9, 2022
@Affie
Copy link
Member

Affie commented Jan 13, 2022

Here is the relevant issue: #510

As a user I would like to add factors before their variables exist

I understand the cloud use case, why local? It is doable but adds a layer of complexity.

@jim-hill-r
Copy link
Collaborator

Could we discuss this for local in an engineering talk sometime down the line. I have often wondered what production application code would look like. As I understand it, a sensor reading is effectively providing a factor, so the application code has to create a factor and the associated variables. Does it make sense to just make a function like addSensorReading(someFactorConstructor(), [someVariableConstructor(), someVariableConstructor()].. ie, just pump all the data at once? That would help me understand the need for "phantom" idea on local.

@Affie Affie added the design label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants