Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tree construction code is only compiled once, #1513

Closed
dehann opened this issue Apr 8, 2022 · 2 comments · Fixed by #1565
Closed

Ensure tree construction code is only compiled once, #1513

dehann opened this issue Apr 8, 2022 · 2 comments · Fixed by #1565

Comments

@dehann
Copy link
Member

dehann commented Apr 8, 2022

Compiling should not repeat each time the graph changes and a new tree is constructed. First reported in:

@dehann dehann added this to the v0.0.x milestone Apr 8, 2022
@dehann dehann changed the title Ensure tree construction is only compiled once, Ensure tree construction code is only compiled once, Apr 8, 2022
@Affie
Copy link
Member

Affie commented Jul 5, 2022

Compiling should not repeat each time the graph changes and a new tree is constructed

We have a trade-off between compile and run time. I am seeing the long compile times in parametric as well. I suspect it has something to do with factors as even addFactor takes long.

@dehann
Copy link
Member Author

dehann commented Jul 5, 2022

Clearly some bug or quirk here that's worth figuring out.

I wonder if it has something to do with current attempts to compute numerical gradients for factors in ccw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants