-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GC corruption #120
Comments
Is there a relatively small reproducer? I will be changing how memory management works but I'd like to figure out where this happens first. |
No sorry. I gave up on SuiteSparseGraphBLAS shortly after that (also in my particular case it was a lot slower than SparseArrays, but that also could be my usage of it). |
Ah sorry about that. Is Convex.jl using SparseArrays currently? I can take a look at why it was slower if you'd like |
Yeah, though currently it is a bit of a dynamic mess of what exactly is being used where. In jump-dev/Convex.jl#504 I worked on refactoring it to have a consistent pipeline, among other things. I experimented w/ switching back and forth, you can see the commented lines here: https://github.com/jump-dev/Convex.jl/pull/504/files#diff-e52f82517aa9bce265865136a070cfe938d823edd33d7b19ff6d0cde4a2ad584R132-R177 (though I think SparseSuiteGraphBLAS also needed the code elsewhere to be tweaked a little bit too). Unfortunately I've kinda dropped that PR, will need to find some energy for Convex.jl again at some point to pick it up :) |
Alrighty I'll give it a look. At worst it'll help me find better performance defaults! |
running the tests of Convex.jl on commit jump-dev/Convex.jl@dc3f4f3
The text was updated successfully, but these errors were encountered: