Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linear_expansion does not work on equations involving linear algebra (array variables) #1231

Open
dylanede opened this issue Aug 23, 2024 · 1 comment

Comments

@dylanede
Copy link

It looks like there's no support for array and matrix operations in linear_expansion, e.g. broadcast.

I also have found that the workaround of performing scalarize on everything prior to linear_expansion can be incredibly slow and memory-hungry for moderately sized systems. For example for a particular system of 407 equations in 407 unknowns, @time for scalarizing equations and variables and then calling linear_expansion gives

129.486180 seconds (699.76 M allocations: 55.483 GiB, 8.34% gc time, 0.08% compilation time)

on my machine.

@bowenszhu
Copy link
Member

I also have found that the workaround of performing scalarize on everything prior to linear_expansion can be incredibly slow and memory-hungry for moderately sized systems.

Thanks for pointing this out and for the PR! I agree this is a performance bottleneck. I have an idea on how to improve this and will aim to have a fix pushed soon this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants