Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use better colors for disassembler #496

Open
lievenhey opened this issue Jul 7, 2023 · 1 comment
Open

use better colors for disassembler #496

lievenhey opened this issue Jul 7, 2023 · 1 comment

Comments

@lievenhey
Copy link
Contributor

the current implementation of the color generation does not respect contrast, which can lead to highly suboptimal results.

I would propose the following:
image
from stackoverflow
implement this lookup table if there are less then 22 colors

if we need more, we should try to split the hsv color space in like 3 saturations and then try to jump in the saturation. (Currently we are only changing the saturation)

@milianw
Copy link
Member

milianw commented Oct 4, 2023

I'm fine with this, but please make sure that it looks good with dark color schemes too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants