Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring ignore_columns from list to set #26

Open
mahedeeb opened this issue Oct 25, 2019 · 0 comments
Open

Refactoring ignore_columns from list to set #26

mahedeeb opened this issue Oct 25, 2019 · 0 comments
Labels
good first issue Good for newcomers refactoring Imporve the quality and the readability of the code. Applying best practice

Comments

@mahedeeb
Copy link
Contributor

Across all the modules, the considered features are updated after taking into account the ignore_columns as follows:

if ignore_columns is not None:
    string_columns = [col_i for col_i in string_columns if col_i not in ignore_columns]

It is a best practice to change the ignore_columns from a list type to set type to speed up the code.
@mahedeeb mahedeeb added the good first issue Good for newcomers label Oct 25, 2019
@mahedeeb mahedeeb added the refactoring Imporve the quality and the readability of the code. Applying best practice label Oct 25, 2019
@mahedeeb mahedeeb mentioned this issue Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring Imporve the quality and the readability of the code. Applying best practice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mahedeeb