Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predicting the targets for more than one dataset. #36

Open
mahedeeb opened this issue Oct 29, 2019 · 0 comments
Open

predicting the targets for more than one dataset. #36

mahedeeb opened this issue Oct 29, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@mahedeeb
Copy link
Contributor

When giving datasets for prediting the target defined under the "predict" key in the hyperparameters, predict_unseen_data overwrite old predictions when we have more than one dataset in the predicted key inside the parameters. This means, it is possible to give one dataset for predicting the target

To Reproduce
parameters = {
"data": {
"train": {"features": train_dataframe, "target": train_target.to_numpy()},
},
"split": {
"method": "kfold", # "method":"kfold"
"fold_nr": 5, # fold_nr:5 , "split_ratios": 0.3 # "split_ratios":(0.3,0.2)
},
"model": {"type": "Ridge linear regression",
"hyperparameters": {"alpha": "optimize", # alpha:optimize
},
},
"metrics": ["r2_score"],
"predict": {
"test1": {"features": test_dataframe},
"test2": {"features": test_dataframe},
}
}

Expected behavior
We should get the labels for datasets test1, test2

Desktop (please complete the following information):

  • OS: any

Additional context
In the current code, the results from test2 will replace the results from test 1 when running the code
model_index_list, save_models_dir, y_test = flow.training(parameters)
i.e we get only y_test

@mahedeeb mahedeeb added the bug Something isn't working label Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant