Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise kaos release tag with cli and backend version #57

Open
WiktorJ opened this issue Oct 28, 2019 · 3 comments
Open

Synchronise kaos release tag with cli and backend version #57

WiktorJ opened this issue Oct 28, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@WiktorJ
Copy link
Contributor

WiktorJ commented Oct 28, 2019

What is the desired change?

The tag in github and dockerhub should be synchronised with versions in cli/setup.py and backend/steup.py.

How will this change improve kaos?

Clear versioning schema.

Any thoughts on the implementation approach?

One possible approach is to extend the github action to not only tag the git repository but also bump the version for steup.py files.

@WiktorJ WiktorJ added the enhancement New feature or request label Oct 28, 2019
@github-actions
Copy link

Thanks for supporting the development of kaos with your first issue! We look forward to handling it.

@WiktorJ
Copy link
Contributor Author

WiktorJ commented Oct 28, 2019

A good idea would be to create VERSION file in the project root and use this in all setup.py in the project.

@WiktorJ WiktorJ self-assigned this Nov 19, 2019
@WiktorJ
Copy link
Contributor Author

WiktorJ commented Nov 19, 2019

Current Approach:

  • New github action which will be triggered on pull request [open, reopen, synchronize, label, unlabel]. This action takes VERSION file from master and updates the version according to label of PR (#major, #minor, or none which means #path) and commits this file to the PR branch.

  • The action that is currently responsible for tagging have to be changed to just take the version from VERSION file instead of calculating it from previous tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant