Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename based on lpg's suggestions #157

Open
Kampfkarren opened this issue Mar 24, 2021 · 2 comments
Open

Rename based on lpg's suggestions #157

Kampfkarren opened this issue Mar 24, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@Kampfkarren
Copy link
Owner

names I would pick:

  • TokenType becomes Token
  • TokenKind becomes TokenType
  • Token becomes SpannedToken
  • TokenReference becomes... SpannedTokenWithTrivia?

Based on @tomprince's work, TokenReference will be WithTrivia<Token>, and potentially Token to Spanned<Token>.
@Kampfkarren Kampfkarren added this to the 1.0.0 milestone Mar 24, 2021
@Kampfkarren Kampfkarren added the enhancement New feature or request label Mar 24, 2021
@tomprince
Copy link
Contributor

I think TokenKind is a better name than TokenType. It lines up better with all the ErrorKind enums, which serve a similar purpose.

@Kampfkarren
Copy link
Owner Author

Yeah, I agree, I'm just copying the old message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@tomprince @Kampfkarren