Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlocking levels Bug when not follow_wanikani #476

Open
tadgh opened this issue Jul 21, 2020 · 0 comments
Open

Unlocking levels Bug when not follow_wanikani #476

tadgh opened this issue Jul 21, 2020 · 0 comments
Assignees
Labels

Comments

@tadgh
Copy link
Collaborator

tadgh commented Jul 21, 2020

There is currently some shared logic between sync, and level unlock, which first checks if a user has follow_me enabled, and if they do not, the level unlocker quite literally ignores. This can be seen in process_vocabulary_response_for_user_v2 in WanikaniUserSyncerV2 https://github.com/Kaniwani/kw-backend/blob/master/api/sync/WanikaniUserSyncerV2.py#L132 , called by https://github.com/Kaniwani/kw-backend/blob/master/api/sync/WanikaniUserSyncerV2.py#L286

The fix is to divorce the logic between sync and manual unlock. This must be a regression for the V2 syncer as this used to work.

@tadgh tadgh self-assigned this Jul 21, 2020
@DJTB DJTB added the bug label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants