Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Eye Icon for Password Visibility #117

Closed
mahmoudnasser1561 opened this issue Mar 1, 2025 · 5 comments
Closed

Add an Eye Icon for Password Visibility #117

mahmoudnasser1561 opened this issue Mar 1, 2025 · 5 comments

Comments

@mahmoudnasser1561
Copy link

Description :

if I forget the rest of the Password when doing login
I'd Like to have password visibility option
this could improve usability

approach :

add an eye icon (👁️) inside the password field.
holding the eye icon reveals the password for few seconds

@01bps
Copy link
Contributor

01bps commented Mar 2, 2025

Good idea! A password visibility toggle can definitely improve usability. Maybe consider a toggle instead of a hold-to-view for better accessibility?

@pradeeban
Copy link
Member

Good one! Yes, toggle sounds great. Alaskan winters can be brutal and if someone is logging in from the streets, they probably are typing with gloves (difficult to type) or removed the glove to type (frostbite sets in real quick). So, every bit of accessibility enhancement is crucial (given the target user base).

Thanks @mahmoudnasser1561 @01bps

@01bps
Copy link
Contributor

01bps commented Mar 3, 2025

Hey @mahmoudnasser1561 , I’m interested in working on this issue. Let me know if you’re already working on it, or if I can take it up.
@pradeeban, if it's available, could you assign it to me?
Thanks!

@mahmoudnasser1561
Copy link
Author

Hi @01bps !
go for it
I'm not working on it right now

@01bps
Copy link
Contributor

01bps commented Mar 4, 2025

Hi @01bps !
go for it
I'm not working on it right now

Thanks for the response! Someone already opened a PR for this while I was confirming it with you. Let me know if I can help with anything else!

Also, are you working on #115, or can I take it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants