New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use crypto random for Voucher Creation #22

Open

totiz opened this issue Jan 27, 2019 · 0 comments

Collaborator

totiz commented Jan 27, 2019 •

edited

Loading

For voucher creation, it better to use crypto random or some lib that give Truly random, consider read this article https://gist.github.com/joepie91/7105003c3b26e65efcea63f3db82dfba.

PKTF/voucher-react/src/App.js

Line 125 in deb05d0

random += possible.charAt(Math.floor(Math.random() * possible.length));

PKTF/voucher-redeem/backend/util.js

Line 6 in deb05d0

text += possible.charAt(Math.floor(Math.random() * possible.length));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment