Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugged method should plug without a callback #35

Open
Keboo opened this issue Nov 18, 2022 · 0 comments
Open

Plugged method should plug without a callback #35

Keboo opened this issue Nov 18, 2022 · 0 comments

Comments

@Keboo
Copy link
Owner

Keboo commented Nov 18, 2022

Right now when you create a plug and apply it.

eg.

var methodPlug = Nasal.Method(Method);
var propertyPlug = Nasal.Property<string>(Property)
//...
using var _ = Nasal.ApplyAsync(methodPlug, propertyPlug);

These plugs are not applied because a callback/return have not been set on them. These then end up doing nothing. These should instead default to empty callbacks (or throwing callbacks) to provide more expected default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant