Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application is referencing nonexistent file ktc-tagmanager.js #30

Closed
Lahvac opened this issue Jun 21, 2024 · 1 comment
Closed

Application is referencing nonexistent file ktc-tagmanager.js #30

Lahvac opened this issue Jun 21, 2024 · 1 comment

Comments

@Lahvac
Copy link

Lahvac commented Jun 21, 2024

Describe the bug
The application shows 404 in browser console for file _content/Kentico.Xperience.TagManager/js/ktc-tagmanager.js

The file was removed in commit 49eb5ba but the scritp tag pointing to this location is still rendered by https://github.com/Kentico/xperience-by-kentico-tag-manager/blob/main/src/Kentico.Xperience.TagManager/Rendering/CodeSnippetTagHelperComponent.cs

To Reproduce
Steps to reproduce the behavior:

  1. Install Kentico.Xperience.TagManager 3.0 or later
  2. run the app
  3. Open browser console on any page
  4. It contains the 404 error

Expected behavior
The file was removed in commit 49eb5ba but the scritp tag pointing to this location is still rendered by https://github.com/Kentico/xperience-by-kentico-tag-manager/blob/main/src/Kentico.Xperience.TagManager/Rendering/CodeSnippetTagHelperComponent.cs

The file should either be provided by the nuget or the script tag should not be rendered.

Library Version
3.0.0-3.1.0

@seangwright
Copy link
Member

I believe the Kentico.Xperience.TagManager.csproj has a copy/pasted line that is incorrect.

BeforeTargets="NpmBuildClient" should be BeforeTargets="NpmBuildHelpScript"

After this change, someone needs to validate that a Release build creates a ktc-tagmanager.js in the wwwroot folder of the build output and that file is included in the generated NuGet package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants