Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading pymatgen to 2024.9.17.1 gives error for pyEQL #192

Closed
abhardwaj73 opened this issue Sep 25, 2024 · 5 comments
Closed

Upgrading pymatgen to 2024.9.17.1 gives error for pyEQL #192

abhardwaj73 opened this issue Sep 25, 2024 · 5 comments

Comments

@abhardwaj73
Copy link
Contributor

abhardwaj73 commented Sep 25, 2024

When using pip install pymatgen -U to upgrade pymatgen, it provides the following error related to pyEQL

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pyeql 1.1.6 requires pymatgen==2024.5.1, but you have pymatgen 2024.9.17.1 which is incompatible.
@abhardwaj73
Copy link
Contributor Author

abhardwaj73 commented Sep 25, 2024

@rkingsbury Is it because the default pyEQL version for pymatgen is still 1.1.6? If so, it must be updated as pymatgen underwent major bugfixes.

@rkingsbury
Copy link
Member

rkingsbury commented Sep 26, 2024

Is it because the default pyEQL version for pymatgen is still 1.1.6?

Not quite. You have pyEQL 1.1.6 installed (try pip freeze | grep pyEQL to see), and it was pinned to pymatgen==2024.5.1 to avoid formula parsing bugs in later versions, but then you updated pymatgen. pip will still allow you to do this, it's just warning you that this does break some of the dependency constraints specified in pyEQL.

Upgrading pyEQL to the latest should resolve this, because thanks to your PR #188 , we have removed the pin to a specific pymatgen version

@rkingsbury
Copy link
Member

Please close if the above makes sense and resolves your concern.

@abhardwaj73
Copy link
Contributor Author

Ah thanks. First updating pyEQL = 1.2.0 and then upgrading pymatgen doesn't have any errors.

@abhardwaj73
Copy link
Contributor Author

Updating pyEQL = 1.2.0 and then upgrading pymatgen resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants