Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zap or zerolog instead of logrus #82

Open
adamchalmers opened this issue May 17, 2023 · 5 comments
Open

Use zap or zerolog instead of logrus #82

adamchalmers opened this issue May 17, 2023 · 5 comments

Comments

@adamchalmers
Copy link

They're much faster logging libraries compared to logrus.

@jessfraz
Copy link
Collaborator

oh I did not know this! we should def switch

@adamchalmers
Copy link
Author

adamchalmers commented May 17, 2023

It's super low-priority but yeah it's significantly slower than some competitors, see these benchmarks. I don't think logging performance will be the priority for any customers, but for the companies that do use Go heavily, using zerolog/zap would make us look more professional + legit

@jessfraz
Copy link
Collaborator

yeah that is dope

@jessfraz
Copy link
Collaborator

one thing that is interesting is we only use logrus for the generation code, not the lib, but idk how to denote that in terms of the deps file

@adamchalmers
Copy link
Author

adamchalmers commented May 17, 2023

Oooh, that's interesting. I just assumed we used logrus in the client because of the Dependabot PRs to bump it. So that makes it much lower priority if it's not actually being included in client code.

Also should be very easy to switch if it's only being used in the generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants