-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zap or zerolog instead of logrus #82
Comments
oh I did not know this! we should def switch |
It's super low-priority but yeah it's significantly slower than some competitors, see these benchmarks. I don't think logging performance will be the priority for any customers, but for the companies that do use Go heavily, using zerolog/zap would make us look more professional + legit |
yeah that is dope |
one thing that is interesting is we only use logrus for the generation code, not the lib, but idk how to denote that in terms of the deps file |
Oooh, that's interesting. I just assumed we used logrus in the client because of the Dependabot PRs to bump it. So that makes it much lower priority if it's not actually being included in client code. Also should be very easy to switch if it's only being used in the generator |
They're much faster logging libraries compared to logrus.
The text was updated successfully, but these errors were encountered: