Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication of minimum Python version #20

Open
DManowitz opened this issue Jan 18, 2024 · 3 comments
Open

No indication of minimum Python version #20

DManowitz opened this issue Jan 18, 2024 · 3 comments

Comments

@DManowitz
Copy link

There is no python_requires in your setup.py or setup.cfg, but there is Python 3.8 code in at least trame_client\utils\web_module.py. Admittedly, Python 3.7 is EOL now, but it may still be used in some places, and there may be similar issues when transitioning between minimum supported Python versions in the future.

@jourdain
Copy link
Collaborator

Ideally trame* should be 3.6 compatible, but indeed, that file has some 3.8 assumption. Also that file is not a true requirement of trame. It will be more for the users of it.

The true bump which should force a python_requires would be related to some asycnio api update. But those should not happen anytime soon.

From your point of you, do you think we should provide a python_requires=>=3.8 or fix that file to be EOL 3.6 compatible?
(We do have users still in 3.6)

@DManowitz
Copy link
Author

I'd say that if trame as a whole is claiming to be 3.6 compatible, then there should be a fix to make this 3.6 compatible. I might also want to put a python_requires>=3.6 (unless that is not actually 3.6 compatible) as a reminder when you decide to increase the minimum supported version of Python.

@DManowitz
Copy link
Author

Also, you might want to make sure your documentation mentions the minimum required Python version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants