Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSLink examples are broken. #156

Closed
2 of 11 tasks
ajain-work opened this issue May 10, 2024 · 3 comments
Closed
2 of 11 tasks

WSLink examples are broken. #156

ajain-work opened this issue May 10, 2024 · 3 comments

Comments

@ajain-work
Copy link

ajain-work commented May 10, 2024

Describe the bug

After introducing msgpack+chunking in PR C++ example is not working.

To Reproduce

Please try to run example

Code

Please check code here

Json data is sent instead of binary.

Expected behavior

example should work.

Platform:

Linux

Device:

  • Desktop
  • Mobile

OS:

  • Windows
  • MacOS
  • Linux
  • Android
  • iOS

Browsers Affected:

  • Chrome
  • Firefox
  • Safari
  • IE (Version)

wslink version:
vMAJOR.MINOR.PATCH

@jourdain
Copy link
Collaborator

Good catch, let me remove it from the repo since it is only compatible with wslink<2

@ajain-work
Copy link
Author

Hi @jourdain, I think it will be good if you can fix the examples instead of removing them. Example are helpful to user. Regards

@jourdain
Copy link
Collaborator

By removing, I'm not talking about the example but the full C++ implementation (Already done). Especially since it does not make sense to keep maintaining a feature that is not used. But if a customer does request the support, it will be easy to revive and update the code. Right now, we don't have funding to maintain that C++ side, so it is easier to remove it to prevent miss usage.

Keep in mind, that it still possible to use wslink<2 in C++ as a client.

Hope that make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants