From edb76bbe2042f00ce92c5ce3a775bfab41c084e1 Mon Sep 17 00:00:00 2001 From: Stephen Aylward Date: Sun, 17 Dec 2023 10:55:12 -0500 Subject: [PATCH 1/6] ENH: Bump setup.py and CI to use ITK v5.4 rc2 This includes enabling shared libraries in itk-module.cmake and addressing CMake policy CMP0135 and its associated warning. --- .github/workflows/build-test-package.yml | 4 ++-- CMakeLists.txt | 6 +++++- itk-module.cmake | 1 + setup.py | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index c56f4d4..729b944 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -3,7 +3,7 @@ name: Build, test, package on: [push,pull_request] env: - itk-git-tag: "v5.3.0" + itk-git-tag: "v5.4rc2" jobs: build-test-cxx: @@ -131,6 +131,6 @@ jobs: ctest --output-on-failure -V -S dashboard.cmake python-build-workflow: - uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@b114bdd01a16855f57df0a973e665e61ac83355d + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@3f63de316255a285b0cac4c819d3d45649738999 secrets: pypi_password: ${{ secrets.pypi_password }} diff --git a/CMakeLists.txt b/CMakeLists.txt index 79e9e51..45a9acf 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,5 +1,9 @@ cmake_minimum_required(VERSION 3.16.3) +if(POLICY CMP0135) + cmake_policy(SET CMP0135 NEW) +endif() + if(CMAKE_CXX_STANDARD EQUAL "11" ) message(FATAL_ERROR "CMAKE_CXX_STANDARD:STRING=11 is not supported in ITK version 5.3 and greater.") endif() @@ -17,7 +21,7 @@ endif() project(MorphologicalContourInterpolation) if(NOT ITK_SOURCE_DIR) - find_package(ITK 4.9 REQUIRED) + find_package(ITK REQUIRED) list(APPEND CMAKE_MODULE_PATH ${ITK_CMAKE_DIR}) include(ITKModuleExternal) else() diff --git a/itk-module.cmake b/itk-module.cmake index c1e275c..c06a6f6 100644 --- a/itk-module.cmake +++ b/itk-module.cmake @@ -3,6 +3,7 @@ of manually segmented anatomical contours. Enabling testing requires RLEImage module to be enabled.") itk_module(MorphologicalContourInterpolation + ENABLE_SHARED DEPENDS ITKBinaryMathematicalMorphology ITKDistanceMap diff --git a/setup.py b/setup.py index 8e06757..1721cd6 100644 --- a/setup.py +++ b/setup.py @@ -49,6 +49,6 @@ keywords='ITK InsightToolkit Segmentation Interpolation-methods', url=r'https://github.com/KitwareMedical/ITKMorphologicalContourInterpolation', install_requires=[ - r'itk>=5.3.0' + r'itk>=5.4rc2' ] ) From 5464e2e8be643e546da4d6238097fb8636e35723 Mon Sep 17 00:00:00 2001 From: Stephen Aylward Date: Sun, 17 Dec 2023 10:59:43 -0500 Subject: [PATCH 2/6] BUG: Tag is v5.4rc02 - adding missing 0 --- .github/workflows/build-test-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index 729b944..d5a579e 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -3,7 +3,7 @@ name: Build, test, package on: [push,pull_request] env: - itk-git-tag: "v5.4rc2" + itk-git-tag: "v5.4rc02" jobs: build-test-cxx: From b38c10a235fa2b3cd9f9f531a9de5f1f3562b15a Mon Sep 17 00:00:00 2001 From: Stephen Aylward Date: Sun, 17 Dec 2023 11:55:46 -0500 Subject: [PATCH 3/6] ENH: Eliminate old compiler requirements --- CMakeLists.txt | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 45a9acf..0cb9835 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -4,20 +4,6 @@ if(POLICY CMP0135) cmake_policy(SET CMP0135 NEW) endif() -if(CMAKE_CXX_STANDARD EQUAL "11" ) - message(FATAL_ERROR "CMAKE_CXX_STANDARD:STRING=11 is not supported in ITK version 5.3 and greater.") -endif() - -if(NOT CMAKE_CXX_STANDARD) - set(CMAKE_CXX_STANDARD 14) # Supported values are ``14``, ``17``, and ``20``. -endif() -if(NOT CMAKE_CXX_STANDARD_REQUIRED) - set(CMAKE_CXX_STANDARD_REQUIRED ON) -endif() -if(NOT CMAKE_CXX_EXTENSIONS) - set(CMAKE_CXX_EXTENSIONS OFF) -endif() - project(MorphologicalContourInterpolation) if(NOT ITK_SOURCE_DIR) From c69fce0af5fe740be6a5e30ce57c492e7aed8e59 Mon Sep 17 00:00:00 2001 From: Stephen Aylward Date: Sun, 17 Dec 2023 16:56:44 -0500 Subject: [PATCH 4/6] ENH: Update CI build to macos-12 from macos-11 --- .github/workflows/build-test-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index d5a579e..4c43bbd 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -11,7 +11,7 @@ jobs: strategy: max-parallel: 3 matrix: - os: [ubuntu-20.04, windows-2022, macos-11] + os: [ubuntu-20.04, windows-2022, macos-12] include: - os: ubuntu-20.04 c-compiler: "gcc" @@ -21,7 +21,7 @@ jobs: c-compiler: "cl.exe" cxx-compiler: "cl.exe" cmake-build-type: "Release" - - os: macos-11 + - os: macos-12 c-compiler: "clang" cxx-compiler: "clang++" cmake-build-type: "MinSizeRel" From a5f0fcb89d3c65f8f9d32e217c6a542a27350b7f Mon Sep 17 00:00:00 2001 From: Stephen Aylward Date: Sun, 17 Dec 2023 17:35:26 -0500 Subject: [PATCH 5/6] ENH: Specify XCode on MacOS --- .github/workflows/build-test-package.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index 4c43bbd..d6b543a 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -42,6 +42,11 @@ jobs: - name: Get specific version of CMake, Ninja uses: lukka/get-cmake@v3.22.2 + - name: 'Specific XCode version' + if: matrix.os == 'macos-12' + run: | + sudo xcode-select -s "/Applications/Xcode_13.2.1.app" + - name: Download ITK run: | cd .. From 6fb73c057f2820ba9064e0dab1721f5a11743592 Mon Sep 17 00:00:00 2001 From: Matt McCormick Date: Tue, 16 Apr 2024 10:26:44 -0400 Subject: [PATCH 6/6] ENH: Bump CI configuration for ITK 5.4rc03 --- .github/workflows/build-test-package.yml | 139 ++--------------------- 1 file changed, 7 insertions(+), 132 deletions(-) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index d6b543a..1685f5b 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -2,140 +2,15 @@ name: Build, test, package on: [push,pull_request] -env: - itk-git-tag: "v5.4rc02" - jobs: - build-test-cxx: - runs-on: ${{ matrix.os }} - strategy: - max-parallel: 3 - matrix: - os: [ubuntu-20.04, windows-2022, macos-12] - include: - - os: ubuntu-20.04 - c-compiler: "gcc" - cxx-compiler: "g++" - cmake-build-type: "MinSizeRel" - - os: windows-2022 - c-compiler: "cl.exe" - cxx-compiler: "cl.exe" - cmake-build-type: "Release" - - os: macos-12 - c-compiler: "clang" - cxx-compiler: "clang++" - cmake-build-type: "MinSizeRel" - - steps: - - uses: actions/checkout@v3 - - - name: Set up Python 3.8 - uses: actions/setup-python@v2 - with: - python-version: "3.8" - - - name: Install build dependencies - run: | - python -m pip install --upgrade pip - python -m pip install ninja - - - name: Get specific version of CMake, Ninja - uses: lukka/get-cmake@v3.22.2 - - - name: 'Specific XCode version' - if: matrix.os == 'macos-12' - run: | - sudo xcode-select -s "/Applications/Xcode_13.2.1.app" - - - name: Download ITK - run: | - cd .. - git clone https://github.com/InsightSoftwareConsortium/ITK.git - cd ITK - git checkout ${{ env.itk-git-tag }} - - - name: Build ITK - if: matrix.os != 'windows-2022' - run: | - cd .. - mkdir ITK-b - cd ITK-b - cmake -DCMAKE_C_COMPILER:FILEPATH="${{ matrix.c-compiler }}" -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_CXX_COMPILER="${{ matrix.cxx-compiler }}" -DCMAKE_BUILD_TYPE:STRING=${{ matrix.cmake-build-type }} -DBUILD_TESTING:BOOL=OFF -DModule_RLEImage:BOOL=ON -GNinja ../ITK - ninja - - - name: Build ITK - if: matrix.os == 'windows-2022' - shell: cmd - run: | - cd .. - mkdir ITK-b - cd ITK-b - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat" - cmake -DCMAKE_C_COMPILER:FILEPATH="${{ matrix.c-compiler }}" -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_CXX_COMPILER="${{ matrix.cxx-compiler }}" -DCMAKE_BUILD_TYPE:STRING=${{ matrix.cmake-build-type }} -DBUILD_TESTING:BOOL=OFF -DModule_RLEImage:BOOL=ON -GNinja ../ITK - ninja - - - name: Fetch CTest driver script - run: | - curl -L https://raw.githubusercontent.com/InsightSoftwareConsortium/ITK/dashboard/itk_common.cmake -O - - - name: Configure CTest script - shell: bash - run: | - operating_system="${{ matrix.os }}" - cat > dashboard.cmake << EOF - set(CTEST_SITE "GitHubActions") - file(TO_CMAKE_PATH "\$ENV{GITHUB_WORKSPACE}/.." CTEST_DASHBOARD_ROOT) - file(TO_CMAKE_PATH "\$ENV{GITHUB_WORKSPACE}/" CTEST_SOURCE_DIRECTORY) - file(TO_CMAKE_PATH "\$ENV{GITHUB_WORKSPACE}/../build" CTEST_BINARY_DIRECTORY) - set(dashboard_source_name "${GITHUB_REPOSITORY}") - if((ENV{GITHUB_REF_NAME} MATCHES "master" OR ENV{GITHUB_REF_NAME} MATCHES "main")) - set(branch "-master") - set(dashboard_model "Continuous") - else() - set(branch "-${GITHUB_REF}") - set(dashboard_model "Experimental") - endif() - set(CTEST_BUILD_NAME "${GITHUB_REPOSITORY}-${operating_system}-\${branch}") - set(CTEST_UPDATE_VERSION_ONLY 1) - set(CTEST_TEST_ARGS \${CTEST_TEST_ARGS} PARALLEL_LEVEL \${PARALLEL_LEVEL}) - set(CTEST_BUILD_CONFIGURATION "Release") - set(CTEST_CMAKE_GENERATOR "Ninja") - set(CTEST_CUSTOM_WARNING_EXCEPTION - \${CTEST_CUSTOM_WARNING_EXCEPTION} - # macOS Azure VM Warning - "ld: warning: text-based stub file" - ) - set(dashboard_no_clean 1) - set(ENV{CC} ${{ matrix.c-compiler }}) - set(ENV{CXX} ${{ matrix.cxx-compiler }}) - if(WIN32) - set(ENV{PATH} "\${CTEST_DASHBOARD_ROOT}/ITK-b/bin;\$ENV{PATH}") - endif() - set(dashboard_cache " - ITK_DIR:PATH=\${CTEST_DASHBOARD_ROOT}/ITK-b - Module_MorphologicalContourInterpolation_BUILD_EXAMPLES:BOOL=ON - BUILD_TESTING:BOOL=ON - ") - string(TIMESTAMP build_date "%Y-%m-%d") - message("CDash Build Identifier: \${build_date} \${CTEST_BUILD_NAME}") - message("CTEST_SITE = \${CTEST_SITE}") - include(\${CTEST_SCRIPT_DIRECTORY}/itk_common.cmake) - EOF - cat dashboard.cmake - - - name: Build and test - if: matrix.os != 'windows-2022' - run: | - ctest --output-on-failure -V -S dashboard.cmake - - - name: Build and test - if: matrix.os == 'windows-2022' - shell: cmd - run: | - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat" - ctest --output-on-failure -V -S dashboard.cmake + cxx-build-workflow: + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.0 + with: + itk-cmake-options: '-DModule_MorphologicalContourInterpolation_BUILD_EXAMPLES:BOOL=ON' python-build-workflow: - uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@3f63de316255a285b0cac4c819d3d45649738999 + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@v5.4.0 + with: + test-notebooks: false secrets: pypi_password: ${{ secrets.pypi_password }}