Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationMetadata without default options #162

Open
tomaszmichalak opened this issue Jun 8, 2020 · 2 comments
Open

OperationMetadata without default options #162

tomaszmichalak opened this issue Jun 8, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tomaszmichalak
Copy link
Member

tomaszmichalak commented Jun 8, 2020

Is your feature request related to a problem? Please describe.
OperationMetadata (a part of NodeMetadata) contains details about action's configuration options (ActionNodeConfig). We use the syntax:

factory = action
config { 
   # the value below is not set, it comes from POJO
   # someKeyWhichValueIsValid = a 
   keyWhichValueIsOverriden = b
}

In the config node, we specify some custom settings. Now, OperationMetadata contains custom settings only.

Describe the solution you'd like
We expect to have both custom and default settings in OperationMetadata.

Additional context
This is required by Knotx/knotx-fragments-chrome-extension#98.

@tomaszmichalak tomaszmichalak added the enhancement New feature or request label Jun 8, 2020
@oskarjerzyk oskarjerzyk self-assigned this Jun 8, 2020
@marcinus
Copy link
Contributor

marcinus commented Jun 27, 2020

Please refrain from changing contracts for the main domain objects like ActionFactory.
The top-level abstractions should only change when major version number is updated and should be designed with care.
If changing ActionFactory contract is absolutely necessary, please provide default methods in interfaces to preserve backward compatibility.

@tomaszmichalak
Copy link
Member Author

To verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants