You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, only the final fragment state (payload and body) is available for execution log consumers.
Describe the solution you'd like
We want to track all fragment changes per node. So in Knot.x Chrome Extension we can click on the node and see fragment details.
Additional context
This should be an option, it can influence the performance.
The text was updated successfully, but these errors were encountered:
Enhance EventLogEntry, NodeExecutionData.Response and GraphNodeResponseLog with optional Fragment fragment field
Change EventLogEntry.success(...) to store Fragment resulting from just succeded operation
Modify EventLogConverter::getExecutionData(String id) to populate response in NodeExecutionData when transition == null(which does not happen now) and enhance it with Fragment object from EventLogEntry if present.
Modify MetadataConverter::setGraphLogPropertiesFrom(GraphNodeExecutionLog graphLog, NodeExecutionData executionData) to populate logged Fragment to the consumer (trivial)
The problem with this solution is turning logging on/off. Currently, TaskExecutionContext which performs the logging is not configurable, neither is TaskEngine nor FragmentsEngine. Populating configuration from FragmentsHandler will require changing and cascading these changes down to execution logic - which in my opinion already became pretty complicated.
Perhaps it would be a good moment to refactor/modularize it further?
@tomaszmichalak could you share your point of view on these issues?
Is your feature request related to a problem? Please describe.
Currently, only the final fragment state (payload and body) is available for execution log consumers.
Describe the solution you'd like
We want to track all fragment changes per node. So in Knot.x Chrome Extension we can click on the node and see fragment details.
Additional context
This should be an option, it can influence the performance.
The text was updated successfully, but these errors were encountered: