Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to write platform specific behaviour #283

Closed
2 tasks
lahabana opened this issue May 22, 2024 · 2 comments
Closed
2 tasks

API to write platform specific behaviour #283

lahabana opened this issue May 22, 2024 · 2 comments
Assignees
Milestone

Comments

@lahabana
Copy link
Contributor

lahabana commented May 22, 2024

Problem Statement

We have a few issues that require platform specific behaviour.
While ideally there shouldn't be any, sometimes it is still required.

We should have a component to detect Kubernetes platform information so we can easily write code that's conditional to the platform detected.

Issues that would leverage this component:

Proposed Solution

A lot of the detection code already exists in telemetry: https://github.com/Kong/kubernetes-telemetry/blob/a8f70df68515496b91e46e04fead4116e1df25b9/pkg/telemetry/workflowsk8s.go#L32-L63

Some open questions:

  • Should we include the version there?
  • Should we include os/arch?
  • What kind of refresh policy should we adopt here (my guess is that we don't need to as to the controller pod needs to be restarted to get on the latest k8s node version)?

As this detection is based on heuristics it should be possible for users to set it in configuration in case the heuristics are wrong.

Acceptance Criteria

  • There's an API in controllers that enables us to write platform specific code without writing the discovery ourselves
  • Users can explicitly set their platform parameters and not rely on heuristics
@lahabana lahabana added this to the KGO v1.4.x milestone May 22, 2024
@pmalek
Copy link
Member

pmalek commented May 22, 2024

X-referencing archived issue: https://github.com/Kong/gateway-operator-archive/issues/867.

@lahabana lahabana modified the milestones: KGO v1.4.x, KGO v1.5.x Sep 11, 2024
@programmer04 programmer04 self-assigned this Jan 20, 2025
@programmer04
Copy link
Member

programmer04 commented Jan 27, 2025

It does not need to be implemented consider Close as not planned

For

the approach described in #500 is broader and more robust, and it does not require platform-specific behavior.

For

an alternative solution that will always work is proposed in Kong/kubernetes-ingress-controller#7033

@lahabana lahabana closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants