Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KButton text color within KAlerts isn't correct #2559

Open
johncowen opened this issue Jan 7, 2025 · 2 comments
Open

KButton text color within KAlerts isn't correct #2559

johncowen opened this issue Jan 7, 2025 · 2 comments
Assignees
@portikM
Labels
bug Something isn't working

Comments

@johncowen
Copy link
Contributor

See:

The :deep and :slotted usage added in:

Results in KButtons within KAlerts having the wrong colored text.

We've fixed this our end perhaps temporarily for our usecase.
@portikM
Copy link
Member

portikM commented Jan 7, 2025

Created a ticket: https://konghq.atlassian.net/browse/KHCP-14565

@portikM portikM self-assigned this Jan 7, 2025
@portikM portikM added the bug Something isn't working label Jan 7, 2025
@schirrel
Copy link

@portikM i'd like to help on this issue, is it okay?

@johncowen johncowen mentioned this issue Jan 24, 2025
Merged
johncowen added a commit to kumahq/kuma-gui that referenced this issue Jan 24, 2025
@johncowen
fix: maintain tag anchor and key:value styling in KBadges (#3462)
335c1ad 
### current master (I couldn't manage to get a grab with rollover, but
it underlines):

![Screenshot 2025-01-24 at 14 23
55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde)

### With #3460 applied (the mouse
is rolled over the link but the pointer isn't in the grab):

![Screenshot 2025-01-24 at 14 18
00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933)

### With this PR applied (the mouse is rolled over the link but the
pointer isn't in the grab):

![Screenshot 2025-01-24 at 14 17
08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d)

Introduced in Kong/kongponents#2585

I've mentioned a few times I kinda have a different approach to solve
this sort of stuff completely, I might put up a draft PR soon.

Related to:

- Kong/kongponents#2559
- #3323
- #3317

---------

Signed-off-by: John Cowen <[email protected]>
johncowen added a commit to kumahq/kuma-gui that referenced this issue Jan 24, 2025
@johncowen
fix: maintain tag anchor and key:value styling in KBadges (#3462)
7f3567d 
it underlines):

![Screenshot 2025-01-24 at 14 23
55](https://github.com/user-attachments/assets/1174fabb-e5e7-45ee-afec-df4ec3769fde)

is rolled over the link but the pointer isn't in the grab):

![Screenshot 2025-01-24 at 14 18
00](https://github.com/user-attachments/assets/8b096d74-d29c-4ce6-beff-3285e3e73933)

pointer isn't in the grab):

![Screenshot 2025-01-24 at 14 17
08](https://github.com/user-attachments/assets/3a65998b-59fb-4f4b-9697-095c3072063d)

Introduced in Kong/kongponents#2585

I've mentioned a few times I kinda have a different approach to solve
this sort of stuff completely, I might put up a draft PR soon.

Related to:

- Kong/kongponents#2559
- #3323
- #3317

---------

Signed-off-by: John Cowen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@portikM portikM

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johncowen @schirrel @portikM