Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build UI for swap feature #2646

Closed
Tracked by #2535
lw-cdm opened this issue Feb 23, 2024 · 17 comments
Closed
Tracked by #2535

Build UI for swap feature #2646

lw-cdm opened this issue Feb 23, 2024 · 17 comments
Assignees

Comments

@lw-cdm
Copy link

lw-cdm commented Feb 23, 2024

No description provided.

@Sokol142196
Copy link

Sokol142196 commented Mar 6, 2024

Version test: https://a7e7bf04.subwallet-webapp.pages.dev/

Please check issues:

  • Do not show Swap quote on Substrate acc on the first time visit page

    2646-SwapQuote

  • Quote show incorrect information when change pair or change Amount

    2646-SwapQuote2

  • solution: if form is invalid, show error on the right block

  • Handle case Swap with Ledger account

    • Expect: Filter out Ledger account if Ledger account is invalid with selected pair.
  • Handle case Swap quote expired when standing on Swap confirmation screen

    • Expect: Still standing on Confirmation screen and show more warning message
  • Clickable area of the Change slippage

    • Expect:
      image
  • Other UI

    • Swap token

      • Actual: Show Token name
      • Expect: Show Network

      image

Sorry, something went wrong.

@nampc1
Copy link

nampc1 commented Mar 6, 2024

  • Error page with this route, click on pDOT token on token page

image

  • Choose default swap pair based on the selected account
  • Animation showing swap quote
  • Swap transaction history item
  • Swap quote loading animation

Sorry, something went wrong.

@Sokol142196
Copy link

Sokol142196 commented Mar 8, 2024

Version test: https://ec76fa9b.subwallet-webapp.pages.dev/

  • UI on transaction confirmation
    image

Sorry, something went wrong.

@Sokol142196
Copy link

Sokol142196 commented Mar 11, 2024

Version test: https://fe247b3c.subwallet-webapp.pages.dev
Please check issues:

  • Do not show popup turn on network on the first time open Swap screen in case stand on Specific account

    • Actual:

    2646-TurnON Network

    • Expect: Show popup turn on message
  • Show error message although user do not input data yet

    • Actual:
      2646-ValidateRecipient

    • Expect: Only validate require data when user click Swap button

Sorry, something went wrong.

@Sokol142196
Copy link

Sokol142196 commented Mar 11, 2024

Version test: https://f4e9eeba.subwallet-webapp.pages.dev/

  • Update fee transaction

    • Actual: Transaction fee on Swap screen differ Confirmation/ History screen
    • Expect: Information as same as on the screens
  • Improve UX: Filter swap token by Sender account (HieuDao feedback)

  • Do not show Account Name on the transaction history details screen in case send internal wallet

    • Expect:
      • If send internal wallet -> show account name
      • If send external wallet -> show address
        image
  • Handle case Ledger account

    • Expect: Discuss more
    • With Recipient account: Filter out Ledger account if Ledger account is invalid with received token
      image
    • With Sender account in case Specific account: Still show Ledger account then click Swap button then show error message not support
      image

Sorry, something went wrong.

@Sokol142196
Copy link

Sokol142196 commented Mar 11, 2024


Improve later

  • Do not reset swap quote
    image

Sorry, something went wrong.

@Sokol142196
Copy link

Sokol142196 commented Mar 12, 2024

Version test: https://b1259d16.subwallet-webapp.pages.dev/
Responsive screen

  • Show incorrect account when changing account
    2646-ChangeAcc2

  • Stick Swap button on bottom screen

Sorry, something went wrong.

@nampc1
Copy link

nampc1 commented Mar 15, 2024

  • We should show all decimals point of the swap amount
  • toAmount input should show the every decimal point value
  • quoteRate, minimumReceived should show 8 decimal points

image

  • Missing logo for Chainflip
  • Stop fetching quote on click swap
  • Resume fetching quote on canceling swap confirmation
  • Add expected arrival time
  • Add low liquidity warning
  • Calculate amount on fee option screen
    image

Sorry, something went wrong.

@nampc1
Copy link

nampc1 commented Mar 16, 2024

  • Need to review performance due to the quote reset interval causing the screen to re-render a lot

Sorry, something went wrong.

@nampc1
Copy link

nampc1 commented Mar 18, 2024

  • The swap quote is delayed and shows no loading animation. It should show skeleton immediately and fill information later
  • Estimated fee should show only 2 decimal points (swap quote, confirmation, tx history)
  • Complete "Are you there screen"
  • Missing chainflip testnet provider logo

Sorry, something went wrong.

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 18, 2024

  • Bug UI when standing on T&C swap screen, Select token

    image

    image

  • Do not show message for Receive account field when switch account
    Steps:

    1. Go to swap screen (All account mode)
    2. Select Swap from account = Substrate account and input valid Recipient account
    3. Switch Swap from account = EVM account and observe the displayed screen

    Actual: Do not show error message

    2646

    Expect: Show error message

  • Handle the case where the token does not have a price id

    • Actual: Show NaN
      image

    • Expect:

      • If token does not have a price id then show [Token symbol]
      • Else then show [Number] [Token Symbol]

Sorry, something went wrong.

@nampc1
Copy link

nampc1 commented Mar 19, 2024

  • Update low liquidity warning content
  • Update T&C content

Sorry, something went wrong.

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 19, 2024

Version test: https://2c8d0f6a.subwallet-webapp.pages.dev/transaction/swap

  • UI bug T&C

image

  • Show incorrect token

    image

Sorry, something went wrong.

@Sokol142196
Copy link

Sokol142196 commented Mar 19, 2024

  • Add delay time when reset quote
  • Highlight time when time of quote reset <= 10 s
  • Update Quote route: USDC --> DOT: @nampc1 handle

Sorry, something went wrong.

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 19, 2024

  • Do not reset quote

    swap

  • Do not reset quote in case change Amount = 0, remove amount

    Issue_2646_2

  • Update content: Please recheck from values -> Invalid input. Re-enter information in the red field and try again

  • Follow-up: Reset data before the deadline expires

Sorry, something went wrong.

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 20, 2024

Version test: https://447d0246.subwallet-webapp.pages.dev/transaction/swap

  • Show incorrect quote rate in case swap USDC -> DOT

    image

Sorry, something went wrong.

@Sokol142196
Copy link

Implemention continues in #2780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants