Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate recipient when make XCM transfer #3895

Open
nampc1 opened this issue Dec 6, 2024 · 3 comments · May be fixed by #3906
Open

Validate recipient when make XCM transfer #3895

nampc1 opened this issue Dec 6, 2024 · 3 comments · May be fixed by #3906
Assignees
Milestone

Comments

@nampc1
Copy link

nampc1 commented Dec 6, 2024

Similar to normal transfer, we need to validate recipient info on the receiving chain

@nampc1
Copy link
Author

nampc1 commented Dec 6, 2024

@PDTnhah PDTnhah linked a pull request Dec 10, 2024 that will close this issue
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Dec 24, 2024

Version test: http://14.224.129.242:8900/s/9yxMC5QLtMFdogB

  • Show incorect message in case XCM
    Actual: Show error message in case account have native token

    Image

    Expect: Allow transfer

  • Re-check min XCM
    Actual: remove logic Min XCM = ED * 1.2

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Dec 27, 2024

Version test: http://14.224.129.242:8900/s/crFztrAdaD7i6nA

  • Do not validate in case Amount < Min amount when XCM
    Actual: Do not show message error, allow transfer

    Image

    Expect: Show error, block transfer

  • Unable to transfer local token on chain
    Actual: Show error Cannot convert 1.2 to a BigInt

    Image

    Expect: Allow transfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants