From ce7bca66a9cb3dfb8e5ad842d553f62e61e23734 Mon Sep 17 00:00:00 2001 From: Abduqodiri Qurbonzoda Date: Thu, 5 Sep 2024 16:55:01 +0300 Subject: [PATCH] Drop the Wasm workaround with using unstable NodeJs version In Kotlin 2.0.20 the workaround is no longer needed as it uses NodeJs 22.0.0+ --- examples/kotlin-multiplatform/build.gradle | 11 ----------- .../templates/invalid-target/wasm-nodejs/build.gradle | 11 ----------- 2 files changed, 22 deletions(-) diff --git a/examples/kotlin-multiplatform/build.gradle b/examples/kotlin-multiplatform/build.gradle index 21cfa997..7c2f66e9 100644 --- a/examples/kotlin-multiplatform/build.gradle +++ b/examples/kotlin-multiplatform/build.gradle @@ -135,14 +135,3 @@ benchmark { register("mingwX64") } } - -// Node.js with canary v8 that supports recent Wasm GC changes -rootProject.extensions.findByType(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension.class).with { - nodeVersion = "21.0.0-v8-canary202309167e82ab1fa2" - nodeDownloadBaseUrl = "https://nodejs.org/download/v8-canary" -} - -// Drop this when node js version become stable -rootProject.tasks.withType(org.jetbrains.kotlin.gradle.targets.js.npm.tasks.KotlinNpmInstallTask.class).configureEach { - args.add("--ignore-engines") -} diff --git a/integration/src/test/resources/templates/invalid-target/wasm-nodejs/build.gradle b/integration/src/test/resources/templates/invalid-target/wasm-nodejs/build.gradle index 84d60e80..fb193dc5 100644 --- a/integration/src/test/resources/templates/invalid-target/wasm-nodejs/build.gradle +++ b/integration/src/test/resources/templates/invalid-target/wasm-nodejs/build.gradle @@ -17,14 +17,3 @@ benchmark { register("wasmJs") } } - -// Node.js with canary v8 that supports recent Wasm GC changes -rootProject.extensions.findByType(org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootExtension.class).with { - nodeVersion = "21.0.0-v8-canary202309167e82ab1fa2" - nodeDownloadBaseUrl = "https://nodejs.org/download/v8-canary" -} - -// Drop this when node js version become stable -tasks.withType(org.jetbrains.kotlin.gradle.targets.js.npm.tasks.KotlinNpmInstallTask.class).configureEach { - args.add("--ignore-engines") -}