Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Continue work on the Palette import / export usage #913

Closed
3 of 6 tasks
Smurf-IV opened this issue Jan 21, 2023 · 11 comments
Closed
3 of 6 tasks
Labels
area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Jan 21, 2023

As per #827 there are still outstanding things to be voted upon:

Next:

@Smurf-IV Smurf-IV added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. labels Jan 21, 2023
@PWagner1
Copy link
Contributor

PWagner1 commented Jan 21, 2023

@PWagner1 PWagner1 pinned this issue Jan 21, 2023
@hopla
Copy link

hopla commented Jan 21, 2023

My votes go to

  1. Add doc's on how to use the various theming options (xml, base, designer, programmatic, etc.)
  2. Add / Update example projects

The rest I could do in my application if needed...

@sdreb3421
Copy link

sdreb3421 commented Jan 21, 2023

I agree with hopla. I rarely use the themes. Generally design my own ui.

@cuppm
Copy link

cuppm commented Jan 23, 2023

Documentation and examples. I think there's way more cool stuff that's available in the current version of Krypton than I know about. And having new showcase for them in examples and documentation would be good.

@Smurf-IV
Copy link
Member Author

After sorting the usage of themes via KrptonManager updates here are my observations on the comments above

Sort loading of Themes (Binary)

No, as binary serialisation always appears to be replaced with a newer version that does not have x security or performance Y thing. So it will stick with xml. It's fast enough for these "One off" stylings

Add / Update example projects

There already are examples on "Custom" Palette usages

  • Loading and applying a saved palette
  • Using the designer to create palete modification and applying that via the "GlobalCustom Palette" equivalent
  • Being able to override the base font used regardless of the colour theme being used.

@SteveAndrews
Copy link

The documentation is wrong:
https://krypton-suite.github.io/Standard-Toolkit-Online-Help/Source/Help/Output/articles/palettes.html

There is no KryptonPalette type, among the HUNDREDS!?!? of Palette types.

Is there somewhere else I should be looking? I'm trying to import an XML theme (you could you json), and I've tried dozens of ways that don't work.

@PWagner1
Copy link
Contributor

PWagner1 commented May 4, 2024

The documentation is wrong: https://krypton-suite.github.io/Standard-Toolkit-Online-Help/Source/Help/Output/articles/palettes.html

There is no KryptonPalette type, among the HUNDREDS!?!? of Palette types.

Is there somewhere else I should be looking? I'm trying to import an XML theme (you could you json), and I've tried dozens of ways that don't work.

Hi @SteveAndrews

Thanks for notifying, yes this documentation is out-of-date. As of V80, you need to be using KryptonCustomPaletteBase then assign it to the KryptonManager as a 'Custom' palette.

@Smurf-IV Should this documentation be removed or updated?

@Smurf-IV
Copy link
Member Author

Smurf-IV commented May 5, 2024

@Wagnerp Should have been done as part of the 1st option, but never got done.
Perhaps re-open this or create a new one, and link back to here ?

@PWagner1
Copy link
Contributor

PWagner1 commented May 5, 2024

@Smurf-IV Going to reopen

@PWagner1 PWagner1 reopened this May 5, 2024
@PWagner1
Copy link
Contributor

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jul 7, 2024

Closing, as Themes work is being superceded with newer ideas.

@Smurf-IV Smurf-IV closed this as completed Jul 7, 2024
@PWagner1 PWagner1 added area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Development

No branches or pull requests

6 participants