Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with ouster-ros v0.10.0+ #12

Open
jhughes50 opened this issue Jan 22, 2024 · 1 comment · May be fixed by #13
Open

Incompatibility with ouster-ros v0.10.0+ #12

jhughes50 opened this issue Jan 22, 2024 · 1 comment · May be fixed by #13

Comments

@jhughes50
Copy link

Ouster removed the px_range and px_signal methods from the packet_format object highlighted in the CHANGELOG. I did a lot of digging to find a new way to get range and signal data from column buffer. I implemented a solution using the col_field method. Additionally, a transform also wanted the ros time so I added that. This fixed all the build issues but there are now some runtime issues since our metadata is out of data, that I'm still working through but would like to push to a branch.

I also used this as an opportunity for code cleanup and documentation.

@versatran01
Copy link
Collaborator

Indeed, there has been significant changes to the ouster driver recently. This decoder is terribly outdated atm. One thing I suggest changing is to get rid of the driver.cpp and just use the ouster version. I forgot why I added it originally, probably due to some incompatible changes that ouster made.

@jhughes50 jhughes50 linked a pull request Feb 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants