Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New polls is created as expired by default #9579

Closed
rich20 opened this issue Nov 9, 2023 · 9 comments
Closed

New polls is created as expired by default #9579

rich20 opened this issue Nov 9, 2023 · 9 comments

Comments

@rich20
Copy link
Member

rich20 commented Nov 9, 2023

To Reproduce

  1. create a poll
  2. let the Poll life span field empty
  3. save the message

Result
The new poll has expired

System information

  • Joomla version: ‎4.4.1-dev
  • Joomla template: CASSIOPEIA
  • Kunena version: 6.2.1-DEV
  • Kunena template: Aurelia
  • Php version: 8.1.22
  • Database version: 10.5.22-MariaDB

Desktop

  • OS: Ubuntu 22.04.1 LTS
  • Browser: Chromium, Firefox and Opera
@rich20 rich20 added this to the 6.2 milestone Nov 9, 2023
@xillibit
Copy link
Member

xillibit commented Nov 9, 2023

I don't have that when i save the message i don't have an error message saying that poll has expired

@rich20
Copy link
Member Author

rich20 commented Nov 9, 2023

I have this problem on one of my test pages. There it also shows outdated codes, although Kunena 6.2.1-DEV is installed.

Deprecated: DateTimeImmutable::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 105

Deprecated: Creation of dynamic property Kunena\Forum\Site\Controller\Topic\Poll\TopicPollDisplay::$intervalTimeToLive is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 106

Deprecated: Creation of dynamic property Kunena\Forum\Libraries\Layout\KunenaLayout::$intervalTimeToLive is deprecated in .../libraries/kunena/src/Layout/KunenaBase.php on line 571
Poll: test (was ended )

xillibit added a commit that referenced this issue Nov 10, 2023
@xillibit
Copy link
Member

Deprecated: Creation of dynamic property Kunena\Forum\Site\Controller\Topic\Poll\TopicPollDisplay::$intervalTimeToLive is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 106

The following commit : c8881c4 should fix that

@rich20
Copy link
Member Author

rich20 commented Nov 10, 2023

Partial success. The "Deprecated: DateTimeImmutable..." is now gone

  • Deprecated: DateTimeImmutable::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 105

  • Deprecated: Creation of dynamic property Kunena\Forum\Site\Controller\Topic\Poll\TopicPollDisplay::$intervalTimeToLive is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 106

  • Deprecated: Creation of dynamic property Kunena\Forum\Libraries\Layout\KunenaLayout::$intervalTimeToLive is deprecated in .../libraries/kunena/src/Layout/KunenaBase.php on line 571

  • Poll: Test (was ended )

@xillibit
Copy link
Member

xillibit commented Nov 10, 2023

I don't reproduce this issue with J!5.0 and Php 8.2.x and MySQL 8.0 :

Poll_issue_timestamp.mp4

@rich20
Copy link
Member Author

rich20 commented Nov 10, 2023

I believe you. Apparently, outdated code is not always displayed. In the case of this error #9562, nobody was able to confirm it for a long time, and yet it was actually there.

One message has now disappeared again with the last correction.

  • Deprecated: DateTimeImmutable::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 105

  • Deprecated: Creation of dynamic property Kunena\Forum\Libraries\Layout\KunenaLayout::$intervalTimeToLive is deprecated in .../libraries/kunena/src/Layout/KunenaBase.php on line 571

  • Deprecated: Creation of dynamic property Kunena\Forum\Site\Controller\Topic\Poll\TopicPollDisplay::$intervalTimeToLive is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 106

  • Poll: Test (was ended )

Copy link

This issue is stale because it has been open 30 days with no activity.

xillibit added a commit that referenced this issue Dec 13, 2023
@810
Copy link
Member

810 commented Apr 13, 2024

@rich20 can you try again, then we can close this one

@rich20
Copy link
Member Author

rich20 commented Apr 14, 2024

Seems to be done

@rich20 rich20 closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants