Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using tidyverse/hms for time type #34

Open
sv opened this issue Sep 13, 2018 · 3 comments
Open

Consider using tidyverse/hms for time type #34

sv opened this issue Sep 13, 2018 · 3 comments

Comments

@sv
Copy link
Contributor

sv commented Sep 13, 2018

https://hms.tidyverse.org/index.html

@sv sv added the help wanted label Sep 13, 2018
@statquant
Copy link
Contributor

What does that bring over difftime ?
What precision do we need ?

@sv
Copy link
Contributor Author

sv commented Sep 16, 2018

We need up to millisecond for time. integer is enough for this.
In current master it converts just to vector of ints. In my branch I have it as POSIXct: which is has date in it and timezone.
difftime has unit only up to seconds, which is not suitable. hms is based on difftime and can go up to microseconds according to description and can play with posixct, be nagative or more then 24hrs

@statquant
Copy link
Contributor

Is this still open?
The nanotime package has a nanoduration class which would be better suited I think. It handles nanoseconds and is using integer64 under the hood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants