Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Invalid Legacy Formatting Warning Specifically with sendActionBar in Older Minecraft Versions #155

Closed
Bram1903 opened this issue Feb 24, 2024 · 1 comment

Comments

@Bram1903
Copy link

Bram1903 commented Feb 24, 2024

Description:
When utilizing the Adventure library's sendActionBar method in a Bukkit plugin on older Minecraft versions (1.8 in this example), a warning related to legacy formatting codes is being erroneously thrown. This warning is specific to the sendActionBar method and does not occur with other methods such as sendMessage or sendTitle. Despite not employing any legacy formatting codes in the codebase, the warning persists, indicating a potential issue within the Adventure library's implementation for older Minecraft versions.

Steps to Reproduce:

  1. Install the provided plugin on a Minecraft server running version 1.8.
  2. Execute the command associated with the plugin that triggers the sendActionBar method, e.g., /showcase.
  3. Observe the console logs for warnings related to legacy formatting codes.

Repository including a showcase project: AdventureBugExample

The plugin can easily be tested by running gradle runServer. This will fire up a paper server running 1.8.8, with the latest build of the plugin.

Expected Behavior:
The sendActionBar method should execute without any warnings related to legacy formatting codes, similar to other message-sending methods such as sendMessage and sendTitle.

Actual Behavior:
Warnings related to legacy formatting codes are specifically thrown when utilizing the sendActionBar method, despite the absence of legacy formatting codes in the codebase. Other message-sending methods do not trigger these warnings.

Additional Information:

  • This issue is not reproducible in version 1.20.4 of Minecraft.
  • The warning specifically occurs with the sendActionBar method, suggesting a potential discrepancy or bug in its implementation for older Minecraft versions.

Environment:

  • Minecraft Version: 1.8
  • Server Software: Paper
  • Adventure Library Version (Bukkit): 4.3.2
  • Operating System: Windows

Possibly related to #86

@zml2008
Copy link
Member

zml2008 commented Feb 24, 2024

There's a client bug in older Minecraft versions that causes the client to not properly handle components sent to the action bar, the legacy text there us a workaround. iirc the legacy warning is gated behind a system property, so just don't enable it if you're working in legacy environments

@zml2008 zml2008 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants