From 06f03a65cd9a86f07da58714e3ba8958e1a51d34 Mon Sep 17 00:00:00 2001 From: Nico <> Date: Fri, 27 Dec 2024 12:53:26 -0300 Subject: [PATCH] cambios nico comments --- .../lacnic/elections/domain/ElectionTest.java | 187 +++--------------- 1 file changed, 28 insertions(+), 159 deletions(-) diff --git a/elections-ejb/src/test/java/net/lacnic/elections/domain/ElectionTest.java b/elections-ejb/src/test/java/net/lacnic/elections/domain/ElectionTest.java index ceb861e..1f3521c 100644 --- a/elections-ejb/src/test/java/net/lacnic/elections/domain/ElectionTest.java +++ b/elections-ejb/src/test/java/net/lacnic/elections/domain/ElectionTest.java @@ -16,6 +16,7 @@ import net.lacnic.ReflectTool; public class ElectionTest extends TestCase { + /** * @return the suite of tests being tested */ @@ -26,176 +27,44 @@ public static Test suite() { public void testElection() { AssertAnnotations.assertType(Election.class, Entity.class); - // fields + // Individual Fields with Multiple Annotations AssertAnnotations.assertField(Election.class, "electionId", Id.class, GeneratedValue.class, SequenceGenerator.class, Column.class); - AssertAnnotations.assertField(Election.class, "migrationId", Column.class); AssertAnnotations.assertField(Election.class, "category", Column.class, Enumerated.class); - AssertAnnotations.assertField(Election.class, "migrated", Column.class); - AssertAnnotations.assertField(Election.class, "startDate", Column.class); - AssertAnnotations.assertField(Election.class, "endDate", Column.class); - AssertAnnotations.assertField(Election.class, "creationDate", Column.class); - AssertAnnotations.assertField(Election.class, "titleSpanish", Column.class); - AssertAnnotations.assertField(Election.class, "titleEnglish", Column.class); - AssertAnnotations.assertField(Election.class, "titlePortuguese", Column.class); - AssertAnnotations.assertField(Election.class, "linkSpanish", Column.class); - AssertAnnotations.assertField(Election.class, "linkEnglish", Column.class); - AssertAnnotations.assertField(Election.class, "linkPortuguese", Column.class); - AssertAnnotations.assertField(Election.class, "descriptionSpanish", Column.class); - AssertAnnotations.assertField(Election.class, "descriptionEnglish", Column.class); - AssertAnnotations.assertField(Election.class, "descriptionPortuguese", Column.class); - AssertAnnotations.assertField(Election.class, "maxCandidates", Column.class); - AssertAnnotations.assertField(Election.class, "votingLinkAvailable", Column.class); - AssertAnnotations.assertField(Election.class, "resultLinkAvailable", Column.class); - AssertAnnotations.assertField(Election.class, "auditorLinkAvailable", Column.class); - AssertAnnotations.assertField(Election.class, "revisionRequest", Column.class); - AssertAnnotations.assertField(Election.class, "onlySp", Column.class); - AssertAnnotations.assertField(Election.class, "resultToken", Column.class); - AssertAnnotations.assertField(Election.class, "defaultSender", Column.class); - AssertAnnotations.assertField(Election.class, "electorsSet", Column.class); - AssertAnnotations.assertField(Election.class, "candidatesSet", Column.class); - AssertAnnotations.assertField(Election.class, "auditorsSet", Column.class); - AssertAnnotations.assertField(Election.class, "randomOrderCandidates", Column.class); - AssertAnnotations.assertField(Election.class, "diffUTC", Column.class); - AssertAnnotations.assertField(Election.class, "candidates", OneToMany.class); - AssertAnnotations.assertField(Election.class, "userVoters", OneToMany.class); - AssertAnnotations.assertField(Election.class, "auditors", OneToMany.class); - AssertAnnotations.assertField(Election.class, "electionTemplates", OneToMany.class); - AssertAnnotations.assertField(Election.class, "votes", OneToMany.class); - AssertAnnotations.assertField(Election.class, "email", OneToMany.class); - AssertAnnotations.assertField(Election.class, "auxStartDate", Transient.class); - AssertAnnotations.assertField(Election.class, "auxStartHour", Transient.class); - AssertAnnotations.assertField(Election.class, "auxEndDate", Transient.class); - AssertAnnotations.assertField(Election.class, "auxEndHour", Transient.class); - AssertAnnotations.assertField(Election.class, "closed", Column.class); - AssertAnnotations.assertField(Election.class, "closedDate", Column.class); - // metodos - AssertAnnotations.assertMethod(Election.class, "getElectionId"); - AssertAnnotations.assertMethod(Election.class, "getStartDate"); - AssertAnnotations.assertMethod(Election.class, "getEndDate"); - AssertAnnotations.assertMethod(Election.class, "getMaxCandidates"); - AssertAnnotations.assertMethod(Election.class, "isVotingLinkAvailable"); - AssertAnnotations.assertMethod(Election.class, "getCandidates"); - AssertAnnotations.assertMethod(Election.class, "getCreationDate"); - AssertAnnotations.assertMethod(Election.class, "getUserVoters"); - AssertAnnotations.assertMethod(Election.class, "getVotes"); - AssertAnnotations.assertMethod(Election.class, "isResultLinkAvailable"); - AssertAnnotations.assertMethod(Election.class, "getTitleSpanish"); - AssertAnnotations.assertMethod(Election.class, "getTitleEnglish"); - AssertAnnotations.assertMethod(Election.class, "getTitlePortuguese"); - AssertAnnotations.assertMethod(Election.class, "getDescriptionSpanish"); - AssertAnnotations.assertMethod(Election.class, "getDescriptionEnglish"); - AssertAnnotations.assertMethod(Election.class, "getDescriptionPortuguese"); - AssertAnnotations.assertMethod(Election.class, "getResultToken"); - AssertAnnotations.assertMethod(Election.class, "getAuditors"); - AssertAnnotations.assertMethod(Election.class, "getLinkSpanish"); - AssertAnnotations.assertMethod(Election.class, "getLinkEnglish"); - AssertAnnotations.assertMethod(Election.class, "getLinkPortuguese"); - AssertAnnotations.assertMethod(Election.class, "getAuxStartDate"); - AssertAnnotations.assertMethod(Election.class, "getAuxStartHour"); - AssertAnnotations.assertMethod(Election.class, "getAuxEndHour"); - AssertAnnotations.assertMethod(Election.class, "getAuxEndHour"); - AssertAnnotations.assertMethod(Election.class, "isOnlySp"); - AssertAnnotations.assertMethod(Election.class, "isAuditorLinkAvailable"); - AssertAnnotations.assertMethod(Election.class, "isElectorsSet"); - AssertAnnotations.assertMethod(Election.class, "isCandidatesSet"); - AssertAnnotations.assertMethod(Election.class, "isAuditorsSet"); - AssertAnnotations.assertMethod(Election.class, "getElectionTemplates"); - AssertAnnotations.assertMethod(Election.class, "getDefaultSender"); - AssertAnnotations.assertMethod(Election.class, "getResultLink"); - AssertAnnotations.assertMethod(Election.class, "isRandomOrderCandidates"); - AssertAnnotations.assertMethod(Election.class, "getStartDateString"); - AssertAnnotations.assertMethod(Election.class, "getDiffUTC"); - AssertAnnotations.assertMethod(Election.class, "isRevisionRequest"); - AssertAnnotations.assertMethod(Election.class, "isFinished"); - AssertAnnotations.assertMethod(Election.class, "isStarted"); - AssertAnnotations.assertMethod(Election.class, "isEnabledToVote"); - AssertAnnotations.assertMethod(Election.class, "isMigrated"); - AssertAnnotations.assertMethod(Election.class, "getCategory"); - AssertAnnotations.assertMethod(Election.class, "isClosed"); - AssertAnnotations.assertMethod(Election.class, "getClosedDate"); + // Grouped Fields with Single Annotation + String[] columnFields = { "migrationId", "migrated", "startDate", "endDate", "creationDate", "titleSpanish", "titleEnglish", "titlePortuguese", "linkSpanish", "linkEnglish", "linkPortuguese", "descriptionSpanish", "descriptionEnglish", "descriptionPortuguese", "maxCandidates", "votingLinkAvailable", "resultLinkAvailable", "auditorLinkAvailable", "revisionRequest", "onlySp", "resultToken", "defaultSender", "electorsSet", "candidatesSet", "auditorsSet", "randomOrderCandidates", "diffUTC", "closed", "closedDate" }; + for (String field : columnFields) { + AssertAnnotations.assertField(Election.class, field, Column.class); + } + + String[] transientFields = { "auxStartDate", "auxStartHour", "auxEndDate", "auxEndHour" }; + for (String field : transientFields) { + AssertAnnotations.assertField(Election.class, field, Transient.class); + } + + String[] oneToManyFields = { "candidates", "userVoters", "auditors", "electionTemplates", "votes", "email" }; + for (String field : oneToManyFields) { + AssertAnnotations.assertField(Election.class, field, OneToMany.class); + } - // class annotations + // Grouped Methods + String[] methods = { "getElectionId", "getStartDate", "getEndDate", "getMaxCandidates", "isVotingLinkAvailable", "getCandidates", "getCreationDate", "getUserVoters", "getVotes", "isResultLinkAvailable", "getTitleSpanish", "getTitleEnglish", "getTitlePortuguese", "getDescriptionSpanish", "getDescriptionEnglish", "getDescriptionPortuguese", "getResultToken", "getAuditors", "getLinkSpanish", "getLinkEnglish", "getLinkPortuguese", "getAuxStartDate", "getAuxStartHour", "getAuxEndDate", "getAuxEndHour", "isOnlySp", "isAuditorLinkAvailable", "isElectorsSet", "isCandidatesSet", "isAuditorsSet", "getElectionTemplates", "getDefaultSender", "getResultLink", "isRandomOrderCandidates", "getStartDateString", "getDiffUTC", "isRevisionRequest", "isFinished", "isStarted", "isEnabledToVote", "isMigrated", "getCategory", "isClosed", "getClosedDate" }; + for (String method : methods) { + AssertAnnotations.assertMethod(Election.class, method); + } + + // Class Annotations Entity a = ReflectTool.getClassAnnotation(Election.class, Entity.class); assertEquals("", a.name()); - Column c; - OneToMany oa; - c = ReflectTool.getFieldAnnotation(Election.class, "electionId", Column.class); + // Specific Annotations + Column c = ReflectTool.getFieldAnnotation(Election.class, "electionId", Column.class); assertEquals("election_id", c.name()); c = ReflectTool.getFieldAnnotation(Election.class, "migrationId", Column.class); assertEquals("migration_id", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "category", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "migrated", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "startDate", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "endDate", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "creationDate", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "titleSpanish", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "titleEnglish", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "titlePortuguese", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "linkSpanish", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "linkEnglish", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "linkPortuguese", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "descriptionSpanish", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "descriptionEnglish", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "descriptionPortuguese", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "maxCandidates", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "votingLinkAvailable", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "resultLinkAvailable", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "auditorLinkAvailable", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "revisionRequest", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "onlySp", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "resultToken", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "defaultSender", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "electorsSet", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "candidatesSet", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "auditorsSet", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "randomOrderCandidates", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "diffUTC", Column.class); - assertEquals("", c.name()); - oa = ReflectTool.getFieldAnnotation(Election.class, "candidates", OneToMany.class); + OneToMany oa = ReflectTool.getFieldAnnotation(Election.class, "candidates", OneToMany.class); assertEquals("election", oa.mappedBy()); oa = ReflectTool.getFieldAnnotation(Election.class, "auditors", OneToMany.class); assertEquals("election", oa.mappedBy()); - oa = ReflectTool.getFieldAnnotation(Election.class, "userVoters", OneToMany.class); - assertEquals("election", oa.mappedBy()); - oa = ReflectTool.getFieldAnnotation(Election.class, "electionTemplates", OneToMany.class); - assertEquals("election", oa.mappedBy()); - oa = ReflectTool.getFieldAnnotation(Election.class, "votes", OneToMany.class); - assertEquals("election", oa.mappedBy()); - oa = ReflectTool.getFieldAnnotation(Election.class, "email", OneToMany.class); - assertEquals("election", oa.mappedBy()); - c = ReflectTool.getFieldAnnotation(Election.class, "closed", Column.class); - assertEquals("", c.name()); - c = ReflectTool.getFieldAnnotation(Election.class, "closedDate", Column.class); - assertEquals("", c.name()); - } - -} \ No newline at end of file +}