Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartitionAssignmentStrategy default value is different from the documented one #374

Closed
8 tasks
3Dmondo opened this issue Oct 3, 2024 · 0 comments · Fixed by #378
Closed
8 tasks

PartitionAssignmentStrategy default value is different from the documented one #374

3Dmondo opened this issue Oct 3, 2024 · 0 comments · Fixed by #378
Milestone

Comments

@3Dmondo
Copy link

3Dmondo commented Oct 3, 2024

Description

The default value of PartitionAssignmentStrategy assigned in the StreamConfig constructor is CooperativeSticky see:

PartitionAssignmentStrategy = Confluent.Kafka.PartitionAssignmentStrategy.CooperativeSticky;
while in the xml documentation it says range:

streamiz/core/StreamConfig.cs

Lines 1966 to 1971 in 940f098

/// <summary>
/// Name of partition assignment strategy to use when elected group leader assigns
/// partitions to group members. default: range importance: medium
/// </summary>
[StreamConfigProperty("partition.assignment.strategy")]
public PartitionAssignmentStrategy? PartitionAssignmentStrategy { get { return _consumerConfig.PartitionAssignmentStrategy; } set { _consumerConfig.PartitionAssignmentStrategy = value; } }

I did experiment KStream-KTable Join issues with the default CooperativeSticky and setting the option to Range solved the issues (as confirmed by this comment #328 (comment)).
It would be nice to have the documentation aligned with the "real" default (and eventually set the default equal to Range as per above mentioned comment).

How to reproduce

Checklist

Please provide the following information:

  • A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
  • A code snippet with your topology builder (ex: builder.Stream<string, string>("topic").to("an-another-topic");)
  • Streamiz.Kafka.Net nuget version.
  • Apache Kafka version.
  • Client configuration.
  • Operating system.
  • Provide logs (with in debug mode (log4net and StreamConfig.Debug) as necessary in configuration).
  • Critical issue.
@LGouellec LGouellec added this to the 1.7.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants