Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sundialsJac does not consistently check for null dstate_dt #52

Open
mcneish1 opened this issue Sep 9, 2019 · 0 comments
Open

sundialsJac does not consistently check for null dstate_dt #52

mcneish1 opened this issue Sep 9, 2019 · 0 comments

Comments

@mcneish1
Copy link

mcneish1 commented Sep 9, 2019

In griddyn/solvers/sundialsInterface.cpp, sundialsJac is allowed to be passed a null dstate_dt. It acknowledges this here and here.

However,

NVECTOR_DATA (sd->use_omp, dstate_dt), filterAd, cj, sd->mode);

and

NVECTOR_DATA (sd->use_omp, dstate_dt), *a1, cj, sd->mode);

do not check for this, and can segfault. These should have the same nullptr check as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant