Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding token support for bitbucket, adding create/mod date for bitbucket #50

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

leebrian
Copy link
Collaborator

We recently had a group start using bitbucket so I took a look at bitbucket support and made two changes.

  1. Added support for token instead of userid and password. I'm not comfortable storing userid and password in config files, or setting it in environment variables. This is kind of a hack as the stashy client doesn't directly allow creating sessions with tokens, so I had to set the internal variable directly and this might break in future versions. So I +1 Consider migrating to atlassian-python-api #43 to switch over to the atlassian new package, although I couldn't easily see how to use a token in that package either.
  2. Previously date was always null, so I added calls to the repo to check commit history for all the commits and set the created and last modified. This ends up being null if it's an empty repository with no commits. This has a performance hit because it makes additional calls for each repo, but it was pretty fast as the calls are small.

@IanLee1521
Copy link
Member

This looks great, thanks!

@IanLee1521 IanLee1521 merged commit 94c4aa4 into LLNL:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants