Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LFO Controller status on playback position change while playing #7528

Open
1 task done
Jan125 opened this issue Oct 1, 2024 · 0 comments
Open
1 task done

Comments

@Jan125
Copy link

Jan125 commented Oct 1, 2024

Enhancement Summary

Submitting in good faith, because I have not seen a similar Issue in the tracker.

Currently, on playback start, the position is accounted for for LFO controllers in determining their beginning state.
This allows consistent playback of sections.

An issue arises when you have position changes while it plays, triggered by:
-Moving the playback cursor with your mouse.
-A loop point being reached.
These events do not trigger a reevaluation of the starting status of the LFO controller, resulting in differing playback.

Implementation Details / Mockup

I propose the following change:
-Update the LFO Controller status on playback position change while playing.
This should not have any breaking issues.

Updating the status on loop points may be a breaking change for some projects that rely on looping multiple times.

Please search the issue tracker for existing feature requests before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant