Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty TCO still acts like BB editor on high zoom #7749

Open
1 task done
Monospace-V opened this issue Mar 3, 2025 · 6 comments
Open
1 task done

Empty TCO still acts like BB editor on high zoom #7749

Monospace-V opened this issue Mar 3, 2025 · 6 comments

Comments

@Monospace-V
Copy link
Contributor

System Information

Windows 11

LMMS Version(s)

1.3.0-alpha.1.780+9159533 (win32/x86_64, Qt 5.15.16, GCC 14.2.0).

Most Recent Working Version

No response

Bug Summary

After #5988, the B/B editor object is no longer drawn by default on an empty piano roll TCO at high zoom levels.
However, if the TCO is highly zoomed in, scrolling over this empty TCO still creates Stepnotes just like scrolling over a B/B tombstone would.

Expected Behaviour

There is no effect; LMMS scrolls over the tracklist like it should do normally.

Steps To Reproduce

  1. Create empty piano roll TCO
  2. Check at the default zoom level or zoom in
  3. Scroll mouse wheel upward while hovering over TCO
  4. See zero-length note appear. Its volume can be adjusted by scrolling too.

Logs

Screenshots / Minimum Reproducible Project

Screen.Recording.2025-03-03.154331.mp4

Please search the issue tracker for existing bug reports before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@Monospace-V Monospace-V added the bug label Mar 3, 2025
@qnebra qnebra added the gui label Mar 3, 2025
@bratpeki
Copy link
Member

bratpeki commented Mar 3, 2025

Can reproduce!

@regulus79
Copy link
Contributor

I believe this feature was intentional when it was originally added. Back then of course it would change rendering to look more like the pattern editor tracks. Not sure how many people find it useful; I think at least a few do. But I do agree, it is confusing.

@zonkmachine
Copy link
Member

When you create an empty tco in the Song editor the default clip type is Type::BeatClip. If you change BeatClip here to MelodyClip you can no longer add a note with the mouse wheel:

m_clipType( Type::BeatClip ),

It's the same function that allows you to add a note and set it's volume in the pattern editor with the mouse wheel.

@Monospace-V
Copy link
Contributor Author

When you create an empty tco in the Song editor the default clip type is Type::BeatClip. If you change BeatClip here to MelodyClip you can no longer add a note with the mouse wheel

In the discussion prior to #5988, we chose to keep legacysebb behaviour a toggle in the configuration XML. This is because it was highly requested.
It is my understanding that doing this would mean we need to remove what was done by that PR and the corresponding switch.
There are users who use the song editor beat/bassline behaviour as it used to be, me included. Could we tie this to legacysebb, or discuss further if needed?

@bratpeki
Copy link
Member

bratpeki commented Mar 4, 2025

I feel like it's unnecessary, especially with Ctrl+dragging from BB into the Song-Editor being a thing.

@Monospace-V
Copy link
Contributor Author

We could tie legacy sebb behaviour to which type of pattern is created by default instead of whether it behaves like a b/b pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants