-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty TCO still acts like BB editor on high zoom #7749
Comments
Can reproduce! |
I believe this feature was intentional when it was originally added. Back then of course it would change rendering to look more like the pattern editor tracks. Not sure how many people find it useful; I think at least a few do. But I do agree, it is confusing. |
When you create an empty tco in the Song editor the default clip type is Type::BeatClip. If you change BeatClip here to MelodyClip you can no longer add a note with the mouse wheel: Line 45 in c12fd57
It's the same function that allows you to add a note and set it's volume in the pattern editor with the mouse wheel. |
In the discussion prior to #5988, we chose to keep legacysebb behaviour a toggle in the configuration XML. This is because it was highly requested. |
I feel like it's unnecessary, especially with Ctrl+dragging from BB into the Song-Editor being a thing. |
We could tie legacy sebb behaviour to which type of pattern is created by default instead of whether it behaves like a b/b pattern. |
System Information
Windows 11
LMMS Version(s)
1.3.0-alpha.1.780+9159533 (win32/x86_64, Qt 5.15.16, GCC 14.2.0).
Most Recent Working Version
No response
Bug Summary
After #5988, the B/B editor object is no longer drawn by default on an empty piano roll TCO at high zoom levels.
However, if the TCO is highly zoomed in, scrolling over this empty TCO still creates Stepnotes just like scrolling over a B/B tombstone would.
Expected Behaviour
There is no effect; LMMS scrolls over the tracklist like it should do normally.
Steps To Reproduce
Logs
Screenshots / Minimum Reproducible Project
Screen.Recording.2025-03-03.154331.mp4
Please search the issue tracker for existing bug reports before submitting your own.
The text was updated successfully, but these errors were encountered: