Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #216

Open
WarnDa opened this issue Jun 3, 2024 · 5 comments
Open

Performance issue #216

WarnDa opened this issue Jun 3, 2024 · 5 comments

Comments

@WarnDa
Copy link

WarnDa commented Jun 3, 2024

Hello,

I am running a +200 players server, and when a lot of player talk in the chat the server get massive freeze (server and chat) and mspt increase to +50
https://spark.lucko.me/DG6PuvKupb
https://spark.lucko.me/pizqyX9Tev

If I disable interactivechat by changing config to :

  PacketsToListen:
    Chat: false
    Title: false

I got no more issue (no freeze, no chat delay at all) and mspt are fine
https://spark.lucko.me/4Nuou0LQVm

@LOOHP
Copy link
Owner

LOOHP commented Jun 3, 2024

Does this problem only appear recently? Since I didn't change the code that much.

From the timings report, it looks like most of the time spent on ticking for InteractiveChat invokes a packet listener in ItemsAdder. Perhaps you can perform some tests to see whether the lag still exists without ItemsAdder? Just to make sure it still happens with InteractiveChat on its own.

@WarnDa
Copy link
Author

WarnDa commented Jun 3, 2024

I got this issue since more than a year, but when you got 50 players it doesn't appear, it's really when getting +150 players

Tried while removing itemsaddder checking for the chat, same :
https://spark.lucko.me/xUHqYFOejk

@LOOHP
Copy link
Owner

LOOHP commented Jun 3, 2024

There's a similar report by another user regarding performance. Yesterday, I've made a slight change in hopes of perhaps improving performance. Perhaps you can try updating to this build from yesterday and see if anything improved. https://ci.loohpjames.com/job/InteractiveChat/285/

@WarnDa
Copy link
Author

WarnDa commented Jun 3, 2024

There's a similar report by another user regarding performance. Yesterday, I've made a slight change in hopes of perhaps improving performance. Perhaps you can try updating to this build from yesterday and see if anything improved. https://ci.loohpjames.com/job/InteractiveChat/285/

My sparks are already on the b285

@dentatar
Copy link

I have similar issues… Testing with just 1 player, but already got ~2 seconds message delay. My setup uses velocity tho, tried with HuskChat and Carbon - same results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants