From f88aabc525d28c66d601051c4396e4bd266cca96 Mon Sep 17 00:00:00 2001 From: Nicolas Ramz Date: Wed, 8 Jan 2025 15:57:52 +0100 Subject: [PATCH] LibJS: Support date strings of the form "Thu, 09 Jan 2025 23:00:00" --- Libraries/LibJS/Runtime/DateConstructor.cpp | 1 + Libraries/LibJS/Tests/builtins/Date/Date.parse.js | 1 + 2 files changed, 2 insertions(+) diff --git a/Libraries/LibJS/Runtime/DateConstructor.cpp b/Libraries/LibJS/Runtime/DateConstructor.cpp index 8847c0a61d0b..10072cda3c34 100644 --- a/Libraries/LibJS/Runtime/DateConstructor.cpp +++ b/Libraries/LibJS/Runtime/DateConstructor.cpp @@ -174,6 +174,7 @@ static double parse_date_string(VM& vm, StringView date_string) "%a%t%b%t%e%t%T%t%Y%t%z"sv, // "Wed Apr 17 23:08:53 2019 +0000" "%Y-%m-%e%t%R%z"sv, // "2021-07-01 03:00Z" "%a,%t%e%t%b%t%Y%t%T%t%z"sv, // "Wed, 17 Jan 2024 11:36:34 +0000" + "%a,%t%d%t%b%t%Y%t%T"sv, // "Thu, 09 Jan 2025 23:00:00" "%a%t%b%t%e%t%Y%t%T%tGMT%t%x%t(%+)"sv, // "Sun Jan 21 2024 21:11:31 GMT 0100 (Central European Standard Time)" "%Y-%m-%e%t%T"sv, // "2024-01-15 00:00:01" "%a%t%b%t%e%t%Y%t%T%t%Z"sv, // "Tue Nov 07 2023 10:05:55 UTC" diff --git a/Libraries/LibJS/Tests/builtins/Date/Date.parse.js b/Libraries/LibJS/Tests/builtins/Date/Date.parse.js index e8343bcdbad8..ac0070390e5f 100644 --- a/Libraries/LibJS/Tests/builtins/Date/Date.parse.js +++ b/Libraries/LibJS/Tests/builtins/Date/Date.parse.js @@ -24,6 +24,7 @@ test("basic functionality", () => { expect(Date.parse("2021-07-01 03:00Z")).toBe(1625108400000); expect(Date.parse("2024-01-08 9:00Z")).toBe(1704704400000); expect(Date.parse("Wed, 17 Jan 2024 11:36:34 +0000")).toBe(1705491394000); + expect(Date.parse("Thu, 09 Jan 2025 23:00:00")).toBe(1736485200000); expect(Date.parse("Sun Jan 21 2024 21:11:31 GMT 0100 (Central European Standard Time)")).toBe( 1705867891000 );