Ashu_Talif_Captain

[dfurda18]

Hi all, I am new in this community. I've installed and created my fork and have been trying out the server. I am getting to the point where I can see some bugs that might've been overlooked since the "what works" website mentions it is already past that point.
I am doing the Aht Urgan mission "The Black Coffin" and it has happened to me repeated times that the enemy Ashu Talif Captain cannot be targeted (you can attack if you wait for it to hit you), but even if you manage to attack, the character won't try to hit making the fight impossible to win.
Looking at the code, I see there's a trigger for 2000 which sets the untargetable to false which is also within a timer, so for some reason it's not being called. I also see a mob:setUnkillable(true) when it spawns, but I don't see where this is reverted, so that could be it.
Edit: That's not the problem, I think the ready variable is not being changed, because the second text:
if ready == 1 and jumped == 0 then
mob:showText(mob, ID.text.OVERPOWERED_CREW)
is not displayed.
I was planning on debugging and fixing this, but before doing it, I wanted to know if this is a known and/or fixed issue, and if it is, which branch is it in?
Thank you for your time.

[TeoTwawki]

Looking at the code, I see there's a trigger for 2000 which sets the untargetable to false which is also within a timer, so for some reason it's not being called.

Hmm this is his roaming/idle code. if this isn't firing I'm guessing he is not in roaming/idle state and has actually agro'd or linked with the crew already. He's supposed to do this jump down animation and then join the crew. In the crew's code I see they have a loop manually engaging other mobs, setting the variable to "ready" .. perhaps some IDs shifted and now he's caught in that (some new mobs were very recently added to the zone, its possible) or was never supposed to be idle for this and nobody caught it the 2000 in the timer call is milliseconds, so that 2 full seconds which might be to much but I'd need to check retail and check how long it is there (youtube videos are not good enough to provide accurate time!) 2 full seconds feels like a guess someone made. Battle ticks come in at far less than that so he'd be engaging pretty much immediately once the animation finishes..

    local jumped = mob:getLocalVar('jump')
    local ready = mob:getLocalVar('ready')

    -- Becomes ready when the Crew is engaged. Jump down!
    if ready == 1 and jumped == 0 then
        mob:showText(mob, ID.text.OVERPOWERED_CREW)
        mob:hideName(true)
        mob:entityAnimationPacket('jmp0')
        mob:timer(2000, function(m)
            m:setPos(0, -22, 13, 192)
            m:entityAnimationPacket('jmp1')
            m:showText(mob, ID.text.TEST_YOUR_BLADES)
            m:timer(2000, function(mAnimation)
                mAnimation:hideName(false)
                mAnimation:setUntargetable(false)
            end)
        end)

        mob:setLocalVar('jump', 1)
    end
end

I also see a mob:setUnkillable(true) when it spawns, but I don't see where this is reverted, so that could be it.

entity.onMobFight = function(mob, target)
    -- The captain gives up at <= 20% HP. Everyone disengages
    local instance = mob:getInstance()
    if mob:getHPP() <= 20 and not instance:completed() then
        instance:complete()
    end

Battle is over once captains hp reaches 20%, even if he's still set unkillable his HP goes down because the flag doesn't stop damages and hp loss.

[TeoTwawki]

I misread part of it but he's probably in an attacking state before the code is finished running in any case.

[dfurda18]

He is not losing health, it makes sense that the fight is now broken after changes from retail. Is there a way to check this on retail other than helping someone on that mission and check is out?

[TeoTwawki]

we'll have to look into why he's not taking damage. I just know the immortal flag (prevents death) doesn't affect that. it'll leave a target at 1hp undying. Is it just that you cannot target him or does he take zero damage even when you do manage to hit him? I think I can still catch untargetables in AoE but maybe someone fixed that - could be related to not taking damage if so.

[dfurda18]

I was watching a video on the fight and I notice some differences:

• The second crew appears instantly. In the private server, it takes a while for them to appear (around 10-15 seconds.
• The Captain appears in the middle once you engage one of the second batch crew members (in the video it is hard to see if there was an animation or not), in the private server, the Captain spawns after 2 seconds. It's not spawned in its starting location, it looks more like behind and above and runs toward the middle.
  I think the following code is not being run:

if ready == 1 and jumped == 0 then
    mob:showText(mob, ID.text.OVERPOWERED_CREW)
    mob:hideName(true)
    mob:entityAnimationPacket('jmp0')
    mob:timer(2000, function(m)
        m:setPos(0, -22, 13, 192)
        m:entityAnimationPacket('jmp1')
        m:showText(mob, ID.text.TEST_YOUR_BLADES)
        m:timer(2000, function(mAnimation)
            mAnimation:hideName(false)
            mAnimation:setUntargetable(false)
            mAnimation:setUnkillable(false)
        end)
    end)

    mob:setLocalVar('jump', 1)

Because I never see the text:
Ashu Talif Captain: You have overpowered my crew...

In the retail video, he is already below and fighting when he says that.

I'm just watching an older video and it is completel different, looks more like what it is coded there. The captain appears two seconds later with a jump animation and two/three seconds later he says the second dialogue:
Ashu Talif Captain: I will test your blades.

[dfurda18]

Ill try to debug and see what is going on. Is there a way to log a variable from the lua script?

[TeoTwawki]

• The Captain appears in the middle once you engage one of the second batch crew members (in the video it is hard to see if there was an animation or not), in the private server, the Captain spawns after 2 seconds. It's not spawned in its starting location, it looks more like behind and above and runs toward the middle.

yeah its meant to be a 2-phase fight. He's supposed to spawn up above un-aggro'd and then jump down (animation, and then the setPos() line moves him so he can agro you) but sounds like he's there off the bat - that would mean he's not idle/roaming so roam code can't fire.

[TeoTwawki]

also, I mistakenly "replied" to the original post instead of our thread and am now kicking myself for it

[dfurda18]

awesome, thank you! I tried that, but I didn't see a change while typing, so I thought it wouldn't be possible.

[dfurda18]

So, if I understand correctly, moving the onMobRoam code to the onMobFight should fix this? Since it is definitely attacking.

[TeoTwawki]

well no, it'd execute his code every battle tick if you did that. We should raise an issue on the tracker for now instead.

[dfurda18]

Well, it allows you to finish the battle, but you don't see the jump animation anymore. It appears where you are already attacking you.

[dfurda18]

so, the mob should go into a roaming state and not link the second crew

[TeoTwawki]

Whole fight should probably be redone to be future-proof. It either was not future proof, or was never 100% correct. I don't see anything stopping it from just wandering around even if the script's had flowed correctly - so what's to stop it from just moving too close and attacking on the 1st wave? Maybe there's an invisible barrier. or maybe someone did a modifier for this mob over at the sql end. but its neither obvious nor documented, and might not exist at all. Anything you or I do here would be a band-aid. raise an issue on the tracker so it can get sorted properly.

[TeoTwawki]

https://github.com/LandSandBoat/server/issues/new/choose

[TeoTwawki]

Linking topic and issue: #4890