Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show operation could be easier to read #12

Closed
3 tasks done
tabacitu opened this issue Aug 29, 2023 · 4 comments
Closed
3 tasks done

[Feature Request] Show operation could be easier to read #12

tabacitu opened this issue Aug 29, 2023 · 4 comments
Assignees

Comments

@tabacitu
Copy link
Member

tabacitu commented Aug 29, 2023

Feature Request

What I am trying to achieve

See the changes in an entry, where I logged everything (not just the dirty). To rephrase, the activity log entry contains the information about the fields that have changed, but also about the fields that have NOT changed. So it's got a lot of info.

Right now the Show view looks like this:
CleanShot 2023-08-29 at 10 50 26@2x

How I see it implemented

I think there are some quick fixes we can do to improve how this looks:

  • 🔴 make the show content span across 12 columns (full-width)
  • 🔴 the table column right now has a max-width of 480px; this doesn't really make sense here;

Those two alone would help it look like this:

CleanShot 2023-08-29 at 10 52 45@2x

I think that's much better already. If we want to go a little further:

  • 🟡 I think it would be SUPER helpful to highlight the attributes that are different, in a certain color. Using basic diffing colors. We could quickly do that with some custom JS, that we inject into the page, and compares the table cell content - if different, it highlights it. So we'd end up with:
CleanShot 2023-08-29 at 10 59 41@2x

In my opinion, the above is much more helpful to spot the differences between the old and the new.

@tabacitu
Copy link
Member Author

tabacitu commented Aug 29, 2023

Of course... we could take this further:

  • 🔵 We could eliminate the changes column, and show that info in a widget below. That way, we would win more horizontal space, it would look prettier and it would give us the flexibility to do whatever we want with the changes diff (the table). But that would be overkill at this point, imho.

@pxpm
Copy link
Contributor

pxpm commented Aug 29, 2023

I think your last proposal is the better, since I would like to also propose that we only show the diff attributes at first, and maybe add a [+] Show more button for the unchaged attributes.

@tabacitu
Copy link
Member Author

Update: did the MUST and SHOULDs in #15

We can also do the COULD, yes.

I don't see a lot of benefit in having a "Show unchanged" button. Since this page's whole reason to exist is to show the activity log... if the developer has chosen to log the unchanged... I think the unchanged should be shown. Highlighting is one thing... hiding content is another, if you ask me. 🤷‍♂️

@tabacitu
Copy link
Member Author

Since most of the stuff here is done, I'm going to close this issue and open a new one about the COUD-DO - #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants