Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Login page body should have a body class for styling #369

Open
pekka opened this issue Jan 16, 2023 · 3 comments
Open

[Feature Request] Login page body should have a body class for styling #369

pekka opened this issue Jan 16, 2023 · 3 comments
Labels
Feature Request Priority: SHOULD

Comments

@pekka
Copy link

pekka commented Jan 16, 2023

The login page (and other pages that use the plain.blade.php template) should have a body CSS class that allows us to target specific pages for styling.

To achieve this, I did this in my local copy of plain.blade.php

<body class="app flex-row align-items-center {{ str_replace(".", "-", Route::current()->getName()); }}">

which on the login page results in

<body class="app flex-row align-items-center backpack-auth-login">

But there might be a more elegant, Laravel-y way.
@welcome
Copy link

welcome bot commented Jan 16, 2023

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

  • Bug Reports, Feature Requests - Github Issues (here);
  • Quick help (How do I do X) - Gitter Chatroom;
  • Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
  • Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

@pxpm
Copy link

pxpm commented Jan 19, 2023

Hey @pekka thanks again for the suggestion.

We are completely re-writing the theming/asset system in Backpack v6 (due next months).

I think this could be a good idea at first glance, need to check if it's scalable/maintanable but it's seems like a good approach.

Thanks for sharing your solution! 🙏

I will add this to v6 development branch so that we talk about it later!

Wish you the best 👍

@pxpm pxpm transferred this issue from Laravel-Backpack/CRUD Jan 19, 2023
@pxpm pxpm removed this from This week Jan 19, 2023
@pekka
Copy link
Author

pekka commented Jan 19, 2023 •
edited
Loading

👍👍

We are completely re-writing the theming/asset system in Backpack v6 (due next months).

oohhh that is very good to know. Looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Priority: SHOULD
Projects
Backpack v6.x (July 2023-Feb 2024)
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pekka @tabacitu @pxpm