Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: WidgetContainer #36

Open
MatteoPiovanelli-Laser opened this issue May 17, 2023 · 1 comment
Open

Perf: WidgetContainer #36

MatteoPiovanelli-Laser opened this issue May 17, 2023 · 1 comment

Comments

@MatteoPiovanelli-Laser
Copy link
Contributor

https://github.com/LaserSrl/Laser.Orchard.Platform/blob/593edf00dd4c47bdd9d45af35681121c8b038a3a/src/Modules/Contrib.Widgets/Services/WidgetManager.cs#LL26C31-L26C31

What I think this is doing:

We should test whether any of those additional Loading queries is firing. I suppose so, and some of this may be partly responsible for the slowdowns we are seeing, because we tend to use a lot of these widgets everywhere. In WidgetService (https://github.com/LaserSrl/Orchard/blob/95a5782d725f00dc168e4e7f53bd5a88102eb7f2/src/Orchard.Web/Modules/Orchard.Widgets/Services/WidgetsService.cs#L74) They use QueryHintsto expand theCommonPart`. It may be wort to test whether that helps our cases.

@HermesSbicego-Laser
Copy link
Contributor

We can use SQL profiler in order to confirm if it fires too many queries.
Then if confirmed we could try to reduce their number if possible.
Large use of widgets can impact on performance, but definitely we have not another way to compose pages.
So, we need to reduce SQL queries execution time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants