Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Smartspacer as At A Glance layout issues #5206

Closed
amcoder opened this issue Jan 25, 2025 · 0 comments · Fixed by #5207
Closed

[BUG] Smartspacer as At A Glance layout issues #5206

amcoder opened this issue Jan 25, 2025 · 0 comments · Fixed by #5207
Labels
bug

Comments

@amcoder
Copy link
Contributor

amcoder commented Jan 25, 2025

Describe the bug

After #5204, the layout of Smartspacer as At a Glance is still a little wonky. If there are multiple cards, and the previous card is long enough that it goes to the right edge of the screen, the unclipped text is still visible.

Steps to reproduce

Steps to reproduce the behavior:

  1. Set Smartspacer as the At a Glance provider
  2. Have a Smartspacer target that is longer than the cars width
  3. Scroll to the next card
  4. See right edge of previous card on acreen

Expected behavior

I think we should have it work the same way as the stock launcher's At a Glance. On the stock launcher the view pager is only as wide as padded area and the content is clipped, so it is not visible behind the padding during scroll.

Screenshots

Example of card content visible behind padding
Image

Example of previous card visible to the left of current card
Image

Example of scrolling stock At a Glance
Image

Device information

  • Device: Pixel 8 Pro, 9 Pro XL Emulator
  • OS: Android 15
  • App version: nightly

Additional context

I will take a look at this later tonight and fix it.
@amcoder amcoder added the bug label Jan 25, 2025
amcoder added a commit to amcoder/lawnchair that referenced this issue Jan 25, 2025
@amcoder
fix: smartspacer layout
da4adec 
Modified the smartspacer layout to be more like the stock At a Glance
layout by adding equal padding to both sides and clipping the pages as
they are scrolled.

Fixes LawnchairLauncher#5206
amcoder added a commit to amcoder/lawnchair that referenced this issue Jan 25, 2025
@amcoder
fix: smartspacer layout
f5a7842 
Modified the smartspacer layout to be more like the stock At a Glance
layout by adding equal padding to both sides and clipping the pages as
they are scrolled.

Fixes LawnchairLauncher#5206
@amcoder amcoder mentioned this issue Jan 25, 2025
Merged
MrSluffy pushed a commit that referenced this issue Jan 25, 2025
@amcoder
fix: smartspacer layout (#5207)
011845a 
Modified the smartspacer layout to be more like the stock At a Glance
layout by adding equal padding to both sides and clipping the pages as
they are scrolled.

Fixes #5206
nulldrf pushed a commit to nulldrf/lawnchair that referenced this issue Jan 25, 2025
@amcoder @nulldrf
fix: smartspacer layout (LawnchairLauncher#5207)
4e3fa1e 
Modified the smartspacer layout to be more like the stock At a Glance
layout by adding equal padding to both sides and clipping the pages as
they are scrolled.

Fixes LawnchairLauncher#5206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: smartspacer layout amcoder/lawnchair
1 participant
@amcoder