Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx blocks missing case in start_service in Operators info service #265

Open
supernovahs opened this issue Feb 2, 2025 · 3 comments
Open
Labels
bug Something isn't working

Comments

@supernovahs
Copy link
Collaborator

supernovahs commented Feb 2, 2025

Currently we use start the service with the current block number .

there is a gap between processing old logs and when we start subscribing to new logs.

h/t @najeal

@supernovahs supernovahs added the bug Something isn't working label Feb 2, 2025
@supernovahs supernovahs changed the title Remove the use of current block number in start_service in Operators info service FIx blocks missing case in start_service in Operators info service Feb 2, 2025
@supernovahs
Copy link
Collaborator Author

supernovahs commented Feb 2, 2025

I think the solution is to run Run Query & Subscription in Parallel

@najeal
Copy link

najeal commented Feb 3, 2025

@supernovahs it is exactly what I thought about, starting to listen and get the history in the background.
If you are ok with that I can propose a PR to resolve the bug

@supernovahs
Copy link
Collaborator Author

that would be great thanks

supernovahs added a commit that referenced this issue Feb 12, 2025
Fixes #265 

### What Changed?
when starting service operatorsinfo_inmemory, the service starts to
listen for new events while fetching operator state history. This avoid
waiting to get the history then miss blocks.

### Reviewer Checklist

- [ ] New features are tested and documented
- [ ] PR updates the changelog with a description of changes
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it

---------

Co-authored-by: supernova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants