Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoenix instrumenter blows up on 404s. #5

Open
electricshaman opened this issue Jan 26, 2018 · 3 comments
Open

Phoenix instrumenter blows up on 404s. #5

electricshaman opened this issue Jan 26, 2018 · 3 comments

Comments

@electricshaman
Copy link

https://github.com/LeToteTeam/dc/issues/470
@keathley
Copy link
Collaborator

keathley commented Jan 26, 2018 •
edited
Loading

I actually don't understand why the phoenix would fire controller instrumentation callbacks when the plug conn doesn't actually have a phoenix controller in it. Like...are we doing something wrong? Are we supposed to have some fallback controller for this?

@GregMefford
Copy link
Contributor

Yeah I thought there was a thing in the v0.2.0 release of Metrix that solved this, but it turned out to not work.

@keathley
Copy link
Collaborator

I'm just very confused as to why phoenix would give us "controller instrumentation" when there's no controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@electricshaman @GregMefford @keathley