Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.mjs #2675

Open
Tracked by #2542
JPMeehan opened this issue Jul 26, 2024 · 1 comment
Open
Tracked by #2542

Update types.mjs #2675

JPMeehan opened this issue Jul 26, 2024 · 1 comment
Labels
foundry v12 This belongs to Foundry VTT version 12

Comments

@JPMeehan
Copy link
Collaborator

JPMeehan commented Jul 26, 2024

resources/app/common/types.mjs

  • Consider if these are still supposed to be in the global scope or to change them to module exports as types a la client.mjs
  • Make individual type fixes for the v11=>v12 changes
  • Possibly the "correct export" for Add _types.mjs #2674
@JPMeehan JPMeehan added the foundry v12 This belongs to Foundry VTT version 12 label Jul 27, 2024
@JPMeehan
Copy link
Collaborator Author

JPMeehan commented Jul 30, 2024

another TODO left from #2600 and #2743 - remove DocumentModificationContext.

  • Foundry leaves the options for _preCreate functionally untyped (object without corresponding typedef)
  • Type should be an easily extensible interface, as at least for _preCreate the options are largely forwarded from the initial operation

JPMeehan pushed a commit that referenced this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foundry v12 This belongs to Foundry VTT version 12
Projects
None yet
Development

No branches or pull requests

1 participant