Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Add a Recent Deals Section #201

Open
jamesqquick opened this issue Jun 25, 2024 · 1 comment
Open

[FEATURE]: Add a Recent Deals Section #201

jamesqquick opened this issue Jun 25, 2024 · 1 comment
Milestone

Comments

@jamesqquick
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
As a user, I want to see a few of the most recently posted deals.

Describe the solution you'd like
Created another section under the featured section for recently deals.

Describe the benefits of your solution
This will highlight the most recent deals.

@jamesqquick jamesqquick added this to the MVP 2 milestone Jun 25, 2024
@HoldUpFjord
Copy link

Hey I'd be interested in picking this up! I know it's relatively big as a first issue but I think I could get this over the line.

After a cursory look, it looks like I'd need to:

  1. Create a recent deals component
  2. add the new component to the featuredDealsSection.tsx component
  3. Use/create a query in lib/queries:
  • could repurpose getApprovedDealsByCategory and manually pass in 'all' for the category

I don't think we need any new typing since recent is a part of all in this case. Do you have any idea about the design? Would you want a tab/navbar like what is implemented in categories? Or would you rather extend the featured sections like so:
image

I've probably overlooked, but would love to talk more about this ticket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants