Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

Changes to grid.editors.config.js file can be lost in Umbraco Cloud #104

Open
matpeder opened this issue Nov 22, 2018 · 2 comments
Open

Comments

@matpeder
Copy link

I've been researching some issues we've had with LeBlender grid editors disappearing in our Umbraco Cloud project. I'm new to Umbraco in general so bear with me, if I got anything wrong.

It seems that the changes LeBlender makes to grid.editors.config.js is not committed to the git repository of an Umbraco Cloud project. This risks hard resets of the file whenever the Umbraco Cloud pulls changes to the file from the repo (ie. when deploying upon committing to the repo from a local solution or when upgrading Umbraco).

If this is the right analysis, I suspect this might be at the core of cloud upgrade issues like these:

To be fair I can't determinate if the ball is in Umbraco's court or not, but if Umbraco Cloud exposes a hook for LeBlender to call when writing to grid.editors.config.js, this might fix this issue? Or am I missing something? Other backoffice changes seem to trigger their own commits in the repo, so I assume there is a protocol for this?

I would love to do a pull request, but I can't seem to figure out where Umbraco Cloud's backoffice API is documented or if it's even possible to call a "push uncomitted changes to repo" method, which seems to be the issue here.

@soreng
Copy link
Contributor

soreng commented Feb 7, 2019

Hi Mathias,

Are you creating the editors locally or remote?

I think I understand the issue if you are doing it remotely. If you are doing it locally, you are committing the file to git, to push it to umbraco cloud.

The "real" solution here, would be that umbraco deploy picks up the changes, and creates a new (version) file that will be pushed. There is a deploy contrib project that may give some insights on how to do this, but I havent looked into it

@AndersBrohus
Copy link

Is there any problems or not? :)

Because i'm thinking of moving the items into a package.manifest in a custom package :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants