Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

When a new property is added to a LeBlender grid editor, it breaks editing #89

Open
geoffbeaumont opened this issue Feb 9, 2018 · 6 comments

Comments

@geoffbeaumont
Copy link

If you add a new field to an existing LeBlender type grid editor then when you try to edit existing instances of this content in grid fields, the properties sidebar will be blank.

I'd expect to be able to at least add new fields without the editor breaking - they should just be defaulted to their normal "empty" state.

@OlePc
Copy link

OlePc commented Mar 7, 2018

I get this too. Seems like the issue was introduced after Umbraco 7.7 was released, and is related to #87

@geoffbeaumont
Copy link
Author

I've applied the fix from that issue and can create new properties - this is an entirely separate issue. It looks like when the grid editor opens the sidebar it tries to instantiate each field editor with the existing value from the grid editor, and falls over if that field property doesn't exist because that grid editor instances was created before the field was added. Looks like it just needs a check to see if the property exists and if not instantiate the field with no/default value as it would for a new instance.

@ulrichebsen
Copy link

ulrichebsen commented Apr 2, 2018

There is a spelling error in line 139 of parameterconfig.controller.js saying "editr" instead of "editor"... fix that and everything works again.. ;)

@RasmusEdvardsen
Copy link

Hey guys, I am having the same problem as @geoffbeaumont, however it is not solved with the fix that @ulrichebsen posed. Any news on this?

@ulrichebsen
Copy link

@RasmusEdvardsen Did you try to up the serial in ClientDependency.config by 1?

@RasmusEdvardsen
Copy link

Yes, thanks! This works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants